Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2935443003: Properly construct 'less than' sentences (Closed)

Created:
3 years, 6 months ago by dullweber
Modified:
3 years, 6 months ago
Reviewers:
msramek
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly construct 'less than X MB' sentences for CBD Currently "less than X MB" and "less than 1 MB" are inserted into "Frees up $1" this might not work correctly when being translated so this CL adds three separate sentences with only a placeholder for "X MB". BUG=725401 Review-Url: https://codereview.chromium.org/2935443003 Cr-Commit-Position: refs/heads/master@{#478581} Committed: https://chromium.googlesource.com/chromium/src/+/8148de4fd6ee28b93a6d2bd40bac79188cf590da

Patch Set 1 #

Patch Set 2 : remove else #

Total comments: 1

Patch Set 3 : fix string description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M chrome/browser/browsing_data/browsing_data_counter_utils.cc View 1 1 chunk +12 lines, -15 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/browsing_data_strings.grdp View 1 2 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
dullweber
Hi Martin, I fixed the "less than X MB" text creation. I currently have "Some ...
3 years, 6 months ago (2017-06-09 13:02:54 UTC) #5
msramek
LGTM. On 2017/06/09 13:02:54, dullweber wrote: > Hi Martin, > I fixed the "less than ...
3 years, 6 months ago (2017-06-09 13:11:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935443003/20001
3 years, 6 months ago (2017-06-09 13:49:14 UTC) #8
msramek
Sorry, I didn't realize that I had a comment which wasn't published by hitting "Reply" ...
3 years, 6 months ago (2017-06-09 14:15:10 UTC) #9
dullweber
On 2017/06/09 14:15:10, msramek (slow) wrote: > Sorry, I didn't realize that I had a ...
3 years, 6 months ago (2017-06-12 08:32:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935443003/40001
3 years, 6 months ago (2017-06-12 08:32:44 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 10:18:20 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8148de4fd6ee28b93a6d2bd40bac...

Powered by Google App Engine
This is Rietveld 408576698