Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2935443002: Decommit unused system pages when invoking WTF::DecommitSystemPages(). (Closed)

Created:
3 years, 6 months ago by tasak
Modified:
3 years, 6 months ago
Reviewers:
haraken, awong, bashi
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Decommit unused system pages when invoking WTF::DecommitSystemPages(). BUG= Review-Url: https://codereview.chromium.org/2935443002 Cr-Commit-Position: refs/heads/master@{#478259} Committed: https://chromium.googlesource.com/chromium/src/+/fec0e7c106a1b36f0e2989a116b820a70c1d56bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/wtf/allocator/Partitions.cpp View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tasak
Would you review this CL?
3 years, 6 months ago (2017-06-09 11:21:57 UTC) #4
haraken
LGTM
3 years, 6 months ago (2017-06-09 13:15:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935443002/1
3 years, 6 months ago (2017-06-09 13:15:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/fec0e7c106a1b36f0e2989a116b820a70c1d56bb
3 years, 6 months ago (2017-06-09 13:20:11 UTC) #12
awong
3 years, 6 months ago (2017-06-12 20:48:11 UTC) #13
Message was sent while issue was closed.
Eek. Too late now as it's committed, but FYI, this is NOT DecommitSystemPages()
at all.  That was the confusion in the first place.

You ended up "discarding" on windows for the windows definition of discarding
which is NOT a decommit.

Powered by Google App Engine
This is Rietveld 408576698