Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2935393002: DevTools: stop whats new from opening on fresh profile (Closed)

Created:
3 years, 6 months ago by chenwilliam
Modified:
3 years, 6 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: stop whats new from opening on fresh profile BUG=713901 Review-Url: https://codereview.chromium.org/2935393002 Cr-Commit-Position: refs/heads/master@{#480268} Committed: https://chromium.googlesource.com/chromium/src/+/22e08ddc30a4911bf9ec2e6b37551990d6f16a54

Patch Set 1 #

Patch Set 2 : tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/inspector/help/release-note.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/help/release-note-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/help/release-note-unit.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/help/release-note-unit-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/help/Help.js View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
chenwilliam
@alph - please take a look. Your office-mate wants this feature :)
3 years, 6 months ago (2017-06-15 22:33:16 UTC) #5
alph
lgtm
3 years, 6 months ago (2017-06-16 22:13:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935393002/20001
3 years, 6 months ago (2017-06-16 23:33:48 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-17 01:58:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/22e08ddc30a4911bf9ec2e6b3755...

Powered by Google App Engine
This is Rietveld 408576698