Issue 29353003: [Object.observe] Don't force normalization of elements for observed objects

Issue 29353003: [Object.observe] Don't force normalization of elements for observed objects (Closed)

Created:
7 years, 2 months ago by rafaelw

Modified:
7 years, 1 month ago

Reviewers:
danno, Jakob Kummerow

CC:
v8-dev, rossberg, adamk, arv (Not doing code reviews)

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

[Object.observe] Don't force normalization of elements for observed objects BUG=v8:2946 R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17601

Patch Set 7 : whitespace #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -49 lines)			Patch
M	src/arm/ic-arm.cc	View	1 2 3 4	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/builtins.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1 2 3 4 5	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/mips/ic-mips.cc	View	1 2 3 4	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/objects.h	View	1 2 3 4 5	5 chunks	+8 lines, -12 lines	0 comments	Download
M	src/objects.cc	View	1 2 3 4 5	8 chunks	+4 lines, -15 lines	0 comments	Download
M	src/objects-debug.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/objects-inl.h	View	1 2 3 4	1 chunk	+4 lines, -7 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1 2 3 4	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

danno

looking good, almost there. https://codereview.chromium.org/29353003/diff/100001/src/arm/ic-arm.cc File src/arm/ic-arm.cc (right): https://codereview.chromium.org/29353003/diff/100001/src/arm/ic-arm.cc#newcode1414 src/arm/ic-arm.cc:1414: __ tst(ip, Operand(1 << Map::kIsObserved)); ...

7 years, 1 month ago (2013-11-06 15:25:11 UTC) #1

rafaelw

ptal https://codereview.chromium.org/29353003/diff/100001/src/arm/ic-arm.cc File src/arm/ic-arm.cc (right): https://codereview.chromium.org/29353003/diff/100001/src/arm/ic-arm.cc#newcode1414 src/arm/ic-arm.cc:1414: __ tst(ip, Operand(1 << Map::kIsObserved)); On 2013/11/06 15:25:11, ...

7 years, 1 month ago (2013-11-07 15:45:07 UTC) #2

danno

lgtm with a comment https://codereview.chromium.org/29353003/diff/150001/src/ia32/ic-ia32.cc File src/ia32/ic-ia32.cc (right): https://codereview.chromium.org/29353003/diff/150001/src/ia32/ic-ia32.cc#newcode882 src/ia32/ic-ia32.cc:882: nit: remove this whitespace change, ...

7 years, 1 month ago (2013-11-08 14:43:42 UTC) #4

rafaelw

https://codereview.chromium.org/29353003/diff/150001/src/ia32/ic-ia32.cc File src/ia32/ic-ia32.cc (right): https://codereview.chromium.org/29353003/diff/150001/src/ia32/ic-ia32.cc#newcode882 src/ia32/ic-ia32.cc:882: On 2013/11/08 14:43:43, danno wrote: > nit: remove this ...

7 years, 1 month ago (2013-11-08 14:53:47 UTC) #5

rafaelw

7 years, 1 month ago (2013-11-08 14:55:24 UTC) #6

Message was sent while issue was closed.

Committed patchset #7 manually as r17601 (presubmit successful).

Expand Messages | Collapse Messages