Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: src/arm/ic-arm.cc

Issue 29353003: [Object.observe] Don't force normalization of elements for observed objects (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: KeyedStoreIC Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/builtins.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1390 matching lines...) Expand 10 before | Expand all | Expand 10 after
1401 __ JumpIfNotSmi(key, &slow); 1401 __ JumpIfNotSmi(key, &slow);
1402 // Check that the object isn't a smi. 1402 // Check that the object isn't a smi.
1403 __ JumpIfSmi(receiver, &slow); 1403 __ JumpIfSmi(receiver, &slow);
1404 // Get the map of the object. 1404 // Get the map of the object.
1405 __ ldr(receiver_map, FieldMemOperand(receiver, HeapObject::kMapOffset)); 1405 __ ldr(receiver_map, FieldMemOperand(receiver, HeapObject::kMapOffset));
1406 // Check that the receiver does not require access checks. We need 1406 // Check that the receiver does not require access checks. We need
1407 // to do this because this generic stub does not perform map checks. 1407 // to do this because this generic stub does not perform map checks.
1408 __ ldrb(ip, FieldMemOperand(receiver_map, Map::kBitFieldOffset)); 1408 __ ldrb(ip, FieldMemOperand(receiver_map, Map::kBitFieldOffset));
1409 __ tst(ip, Operand(1 << Map::kIsAccessCheckNeeded)); 1409 __ tst(ip, Operand(1 << Map::kIsAccessCheckNeeded));
1410 __ b(ne, &slow); 1410 __ b(ne, &slow);
1411 // Check that the receiver is not observed. Observed objects are always
1412 // handled by the runtime.
1413 __ ldrb(ip, FieldMemOperand(receiver_map, Map::kBitFieldOffset));
1414 __ tst(ip, Operand(1 << Map::kIsObserved));
danno 2013/11/06 15:25:11 Here and other platforms, just or this into the co
rafaelw 2013/11/07 15:45:07 Done.
1415 __ b(ne, &slow);
1411 // Check if the object is a JS array or not. 1416 // Check if the object is a JS array or not.
1412 __ ldrb(r4, FieldMemOperand(receiver_map, Map::kInstanceTypeOffset)); 1417 __ ldrb(r4, FieldMemOperand(receiver_map, Map::kInstanceTypeOffset));
1413 __ cmp(r4, Operand(JS_ARRAY_TYPE)); 1418 __ cmp(r4, Operand(JS_ARRAY_TYPE));
1414 __ b(eq, &array); 1419 __ b(eq, &array);
1415 // Check that the object is some kind of JSObject. 1420 // Check that the object is some kind of JSObject.
1416 __ cmp(r4, Operand(FIRST_JS_OBJECT_TYPE)); 1421 __ cmp(r4, Operand(FIRST_JS_OBJECT_TYPE));
1417 __ b(lt, &slow); 1422 __ b(lt, &slow);
1418 1423
1419 // Object case: Check key against length in the elements array. 1424 // Object case: Check key against length in the elements array.
1420 __ ldr(elements, FieldMemOperand(receiver, JSObject::kElementsOffset)); 1425 __ ldr(elements, FieldMemOperand(receiver, JSObject::kElementsOffset));
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
1653 } else { 1658 } else {
1654 ASSERT(Assembler::GetCondition(branch_instr) == ne); 1659 ASSERT(Assembler::GetCondition(branch_instr) == ne);
1655 patcher.EmitCondition(eq); 1660 patcher.EmitCondition(eq);
1656 } 1661 }
1657 } 1662 }
1658 1663
1659 1664
1660 } } // namespace v8::internal 1665 } } // namespace v8::internal
1661 1666
1662 #endif // V8_TARGET_ARCH_ARM 1667 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/builtins.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698