Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2935243002: Revert of [wasm] Increase WebAssembly.Memory maximum size to ~2GB (Closed)

Created:
3 years, 6 months ago by Michael Achenbach
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Increase WebAssembly.Memory maximum size to ~2GB (patchset #10 id:200001 of https://codereview.chromium.org/2903153002/ ) Reason for revert: gc stress failure: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/11122 Original issue's description: > [wasm] Increase WebAssembly.Memory maximum size to 2GB > > BUG=v8:6478, chromium:729768 > > R=bradnelson@chromium.org, eholk@chromium.org > > Review-Url: https://codereview.chromium.org/2903153002 > Cr-Commit-Position: refs/heads/master@{#45931} > Committed: https://chromium.googlesource.com/v8/v8/+/7e6ed62071d2756688a23bd6dac096b0d4660b5d TBR=bradnelson@chromium.org,eholk@chromium.org,gdeepti@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6478, chromium:729768 Review-Url: https://codereview.chromium.org/2935243002 Cr-Commit-Position: refs/heads/master@{#45932} Committed: https://chromium.googlesource.com/v8/v8/+/21ee6d8f8b051448703a0bc12b5fb39573257f43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -98 lines) Patch
M src/compiler/wasm-compiler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/wasm/wasm-limits.h View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -9 lines 0 comments Download
M test/mjsunit/wasm/grow-memory.js View 4 chunks +7 lines, -56 lines 0 comments Download
M test/mjsunit/wasm/import-memory.js View 2 chunks +1 line, -2 lines 0 comments Download
D test/mjsunit/wasm/large-offset.js View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [wasm] Increase WebAssembly.Memory maximum size to ~2GB
3 years, 6 months ago (2017-06-14 06:39:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935243002/1
3 years, 6 months ago (2017-06-14 06:39:42 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 06:39:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/21ee6d8f8b051448703a0bc12b5fb395732...

Powered by Google App Engine
This is Rietveld 408576698