Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2935103002: [Cronet] Strip debug symbols from i386 static framework for iOS. (Closed)

Created:
3 years, 6 months ago by mef
Modified:
3 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Strip debug symbols from i386 static framework for iOS. The size of Cronet library with complete dependencies for i386 exceeds 700mb. This causes problems with internal toolchains. Stripping debug symbols reduces binary size to reasonable 65mb. BUG=721922 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2935103002 Cr-Commit-Position: refs/heads/master@{#479077} Committed: https://chromium.googlesource.com/chromium/src/+/325d2faef60c2a00ea953f943f5287666188476f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M components/cronet/tools/hide_symbols.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
mef
PTAL
3 years, 6 months ago (2017-06-13 15:59:30 UTC) #3
kapishnikov
lgtm
3 years, 6 months ago (2017-06-13 16:24:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935103002/1
3 years, 6 months ago (2017-06-13 18:04:47 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 18:41:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/325d2faef60c2a00ea953f943f52...

Powered by Google App Engine
This is Rietveld 408576698