Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2935093002: Photo Picker dialog: Order selected photos the same as on screen. (Closed)

Created:
3 years, 6 months ago by Finnur
Modified:
3 years, 6 months ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Photo Picker dialog: Order selected photos the same as on screen. BUG=732508, 656015 Review-Url: https://codereview.chromium.org/2935093002 Cr-Commit-Position: refs/heads/master@{#479054} Committed: https://chromium.googlesource.com/chromium/src/+/3741abddbe2c1c03a473d33e68d92902727c8e44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Finnur
Since this was trivial to do, I decided to change from indeterminate order (bad) to ...
3 years, 6 months ago (2017-06-13 15:56:35 UTC) #1
Finnur
3 years, 6 months ago (2017-06-13 15:56:44 UTC) #3
Theresa
lgtm
3 years, 6 months ago (2017-06-13 16:07:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935093002/1
3 years, 6 months ago (2017-06-13 16:18:32 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 16:53:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3741abddbe2c1c03a473d33e68d9...

Powered by Google App Engine
This is Rietveld 408576698