Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2935023002: Revert of [ObjC ARC] Converts ios/web:ios_web_inttests to ARC. (Closed)

Created:
3 years, 6 months ago by stkhapugin
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ObjC ARC] Converts ios/web:ios_web_inttests to ARC. (patchset #1 id:1 of https://codereview.chromium.org/2935683002/ ) Reason for revert: Breaking tests downstream. Original issue's description: > [ObjC ARC] Converts ios/web:ios_web_inttests to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Review-Url: https://codereview.chromium.org/2935683002 > Cr-Commit-Position: refs/heads/master@{#478635} > Committed: https://chromium.googlesource.com/chromium/src/+/dac067a438e47907c38ea2093083f8e7678477b8 TBR=marq@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624363

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ios/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/browser_state_web_view_partition_inttest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/navigation_callbacks_inttest.mm View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
stkhapugin
Created Revert of [ObjC ARC] Converts ios/web:ios_web_inttests to ARC.
3 years, 6 months ago (2017-06-13 09:50:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935023002/1
3 years, 6 months ago (2017-06-13 09:50:27 UTC) #3
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/heads/master'. nothing ...
3 years, 6 months ago (2017-06-13 09:51:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935023002/1
3 years, 6 months ago (2017-06-13 10:46:27 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 10:46:45 UTC) #9
Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/heads/master'.
nothing to commit, working tree clean

Powered by Google App Engine
This is Rietveld 408576698