Improve error handling for file_path.rmtree()

Improve error handling for file_path.rmtree()

If there has been an error while deleting but the directory still disappeared,
do not throw. Use a set to not list the same path mulitple times.

R=vadimsh@chromium.org
BUG=732891
Review-Url: https://codereview.chromium.org/2934983003
Committed: https://github.com/luci/luci-py/commit/32f1b4e8be313e65e99b5de5a7255f66452db4be

[Vadim Sh., 2017-06-13 20:49:02]

https://codereview.chromium.org/2934983003/diff/1/client/utils/file_path.py
File client/utils/file_path.py (right):

https://codereview.chromium.org/2934983003/diff/1/client/utils/file_path.py#n...
client/utils/file_path.py:1169: if errors and fs.exists(root):
as far as I can tell, this code path is not hit on Linux due to 'raise' on line
1119, so it's not the entire fix

[M-A Ruel, 2017-06-15 21:16:34]

Redid the CL, things didn't explode on staging

[Vadim Sh., 2017-06-16 22:18:11]

lgtm with small request

https://codereview.chromium.org/2934983003/diff/20001/client/utils/file_path.py
File client/utils/file_path.py (right):

https://codereview.chromium.org/2934983003/diff/20001/client/utils/file_path....
client/utils/file_path.py:1115: sys.stderr.write(
please add fs.exists(root) here too and ignore any errors if the directory was
actually deleted

[M-A Ruel, 2017-06-17 00:42:57]

https://codereview.chromium.org/2934983003/diff/20001/client/utils/file_path.py
File client/utils/file_path.py (right):

https://codereview.chromium.org/2934983003/diff/20001/client/utils/file_path....
client/utils/file_path.py:1115: sys.stderr.write(
On 2017/06/16 22:18:10, Vadim Sh. wrote:
> please add fs.exists(root) here too and ignore any errors if the directory was
> actually deleted

added at line 1095 instead.

[M-A Ruel, 2017-06-17 00:43:00]

The CQ bit was checked by maruel@chromium.org

[M-A Ruel, 2017-06-17 00:43:00]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2934983003/#ps40001
(title: "fs.exits() call")

[commit-bot: I haz the power, 2017-06-17 00:43:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-17 00:45:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497660180314580,
"parent_rev": "6e1c37c5664d9db2a3b585b92b081ee97c77b105", "commit_rev":
"32f1b4e8be313e65e99b5de5a7255f66452db4be"}

[commit-bot: I haz the power, 2017-06-17 00:45:36]

Description was changed from

==========
Improve error handling for file_path.rmtree()

If there has been an error while deleting but the directory still disappeared,
do not throw. Use a set to not list the same path mulitple times.

R=vadimsh@chromium.org
BUG=732891
==========

to

==========
Improve error handling for file_path.rmtree()

If there has been an error while deleting but the directory still disappeared,
do not throw. Use a set to not list the same path mulitple times.

R=vadimsh@chromium.org
BUG=732891

Review-Url: https://codereview.chromium.org/2934983003
Committed:
https://github.com/luci/luci-py/commit/32f1b4e8be313e65e99b5de5a7255f66452db4be
==========

[commit-bot: I haz the power, 2017-06-17 00:45:38]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/32f1b4e8be313e65e99b5de5a7255f66452db4be