Add support for HTTP range requests in the AppCacheURLLoaderImpl class.

Add support for HTTP range requests in the AppCacheURLLoaderImpl class.

The functions in the AppCacheURLRequest class which parsed the HTTP header to initialize
the range information and setup the range response on receiving an AppCache response
have been moved to the AppCacheJob base class. The member variables to track the AppCache
response, the range response and the input range requests have also been moved to the base
class.

Functions moved/added to the AppCacheJob base class are:
1. InitializeRangeRequestInfo(): Initializes the input range request info.
2. SetupRangeResponse : Sets up the range response information.

BUG=715632
Review-Url: https://codereview.chromium.org/2934953003
Cr-Commit-Position: refs/heads/master@{#479602}
Committed: https://chromium.googlesource.com/chromium/src/+/4c0cb6be7d1846be9fc4c2d6fb2642ead6a3bb1d

[ananta, 2017-06-13 03:52:46]

ananta@chromium.org changed reviewers:
+ jam@chromium.org, michaeln@chromium.org

[ananta, 2017-06-13 03:53:07]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 03:53:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 05:03:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 05:03:02]

Dry run: This issue passed the CQ dry run.

[jam, 2017-06-13 17:54:28]

this looks fine to me, i'll defer to michaeln for final review as he's owner in
these directories

my only comment: can you enable layout tests that now pass?

[michaeln, 2017-06-14 02:37:25]

lgtm!

https://codereview.chromium.org/2934953003/diff/40001/content/browser/appcach...
File content/browser/appcache/appcache_job.h (right):

https://codereview.chromium.org/2934953003/diff/40001/content/browser/appcach...
content/browser/appcache/appcache_job.h:138: net::HttpByteRange
range_requested_;
nit: keep the two range related data members next to each other

https://codereview.chromium.org/2934953003/diff/40001/content/browser/appcach...
File content/browser/appcache/appcache_url_loader_job.cc (right):

https://codereview.chromium.org/2934953003/diff/40001/content/browser/appcach...
content/browser/appcache/appcache_url_loader_job.cc:152:
SetupRangeResponse(reader_.get());
feels a little arbitrary that reader_ is passed in but info_ and range_header_
is not, maybe hoist reader_ into the base class too or don't hoist any and pass
them all as parameters?

[ananta, 2017-06-14 18:52:19]

https://codereview.chromium.org/2934953003/diff/40001/content/browser/appcach...
File content/browser/appcache/appcache_job.h (right):

https://codereview.chromium.org/2934953003/diff/40001/content/browser/appcach...
content/browser/appcache/appcache_job.h:138: net::HttpByteRange
range_requested_;
On 2017/06/14 02:37:24, michaeln wrote:
> nit: keep the two range related data members next to each other

Done.

https://codereview.chromium.org/2934953003/diff/40001/content/browser/appcach...
File content/browser/appcache/appcache_url_loader_job.cc (right):

https://codereview.chromium.org/2934953003/diff/40001/content/browser/appcach...
content/browser/appcache/appcache_url_loader_job.cc:152:
SetupRangeResponse(reader_.get());
On 2017/06/14 02:37:25, michaeln wrote:
> feels a little arbitrary that reader_ is passed in but info_ and range_header_
> is not, maybe hoist reader_ into the base class too or don't hoist any and
pass
> them all as parameters?

Done. Moved reader_ to the base class

[ananta, 2017-06-14 18:52:32]

The CQ bit was checked by ananta@chromium.org

[ananta, 2017-06-14 18:52:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaeln@chromium.org
Link to the patchset: https://codereview.chromium.org/2934953003/#ps60001
(title: "Move AppCacheResponseReader to AppCacheJob base.")

[commit-bot: I haz the power, 2017-06-14 18:53:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 19:01:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 19:01:50]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ananta, 2017-06-15 02:28:07]

The CQ bit was checked by ananta@chromium.org

[ananta, 2017-06-15 02:28:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaeln@chromium.org
Link to the patchset: https://codereview.chromium.org/2934953003/#ps80001
(title: "Fix compile failures")

[commit-bot: I haz the power, 2017-06-15 02:28:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 02:35:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 02:35:26]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ananta, 2017-06-15 02:58:55]

The CQ bit was checked by ananta@chromium.org

[ananta, 2017-06-15 02:58:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaeln@chromium.org
Link to the patchset: https://codereview.chromium.org/2934953003/#ps100001
(title: "Fix SetupRangeResponse definition")

[commit-bot: I haz the power, 2017-06-15 02:59:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 04:27:46]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1497495535467040,
"parent_rev": "76fc114441c30b033be4b3aa74dba49eba5ad072", "commit_rev":
"4c0cb6be7d1846be9fc4c2d6fb2642ead6a3bb1d"}

[commit-bot: I haz the power, 2017-06-15 04:27:59]

Description was changed from

==========
Add support for HTTP range requests in the AppCacheURLLoaderImpl class.

The functions in the AppCacheURLRequest class which parsed the HTTP header to
initialize
the range information and setup the range response on receiving an AppCache
response
have been moved to the AppCacheJob base class. The member variables to track the
AppCache
response, the range response and the input range requests have also been moved
to the base
class.

Functions moved/added to the AppCacheJob base class are:
1. InitializeRangeRequestInfo(): Initializes the input range request info.
2. SetupRangeResponse : Sets up the range response information.

BUG=715632
==========

to

==========
Add support for HTTP range requests in the AppCacheURLLoaderImpl class.

The functions in the AppCacheURLRequest class which parsed the HTTP header to
initialize
the range information and setup the range response on receiving an AppCache
response
have been moved to the AppCacheJob base class. The member variables to track the
AppCache
response, the range response and the input range requests have also been moved
to the base
class.

Functions moved/added to the AppCacheJob base class are:
1. InitializeRangeRequestInfo(): Initializes the input range request info.
2. SetupRangeResponse : Sets up the range response information.

BUG=715632

Review-Url: https://codereview.chromium.org/2934953003
Cr-Commit-Position: refs/heads/master@{#479602}
Committed:
https://chromium.googlesource.com/chromium/src/+/4c0cb6be7d1846be9fc4c2d6fb26...
==========

[commit-bot: I haz the power, 2017-06-15 04:28:02]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/4c0cb6be7d1846be9fc4c2d6fb26...