exo: Reparent pointer surface

exo: Reparent pointer surface

When the display configuration changes, the pointer surface must be
reparented to the new primary display. A client-side bug previously
forced a surface change on pointer enter, causing the surface to be
reparented to the latest primary display.

BUG=730843
TEST=Verify correct parenting by printing window hierarchy.

Review-Url: https://codereview.chromium.org/2934953002
Cr-Commit-Position: refs/heads/master@{#479073}
Committed: https://chromium.googlesource.com/chromium/src/+/f86ddbbc48abb0d8c2ad6ee10a1728ff7e87e00c

[Dominik Laskowski, 2017-06-12 21:47:39]

The CQ bit was checked by domlaskowski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 21:48:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dominik Laskowski, 2017-06-12 21:49:33]

domlaskowski@chromium.org changed reviewers:
+ reveman@chromium.org

[Dominik Laskowski, 2017-06-12 21:49:34]

PTAL. Split from https://codereview.chromium.org/2933133002/

[reveman, 2017-06-12 21:56:09]

Why does it have to be re-parented? Why can't we instead adjust the scale used
for capture?

[Dominik Laskowski, 2017-06-12 22:05:43]

On 2017/06/12 21:56:09, reveman wrote:
> Why does it have to be re-parented? Why can't we instead adjust the scale used
> for capture?

The initial primary display could be removed, in which case we have no other
choice but to reparent.

[reveman, 2017-06-12 22:13:45]

Why not add it to the layer tree at the time of capture and then remove it
when capture completes?

On Jun 12, 2017 6:05 PM, <domlaskowski@chromium.org> wrote:

On 2017/06/12 21:56:09, reveman wrote:
> Why does it have to be re-parented? Why can't we instead adjust the scale
used
> for capture?

The initial primary display could be removed, in which case we have no other
choice but to reparent.

https://codereview.chromium.org/2934953002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[reveman, 2017-06-12 22:15:30]

Maybe not even bother to remove it. Just make sure to add it before each
capture request..

On Jun 12, 2017 6:13 PM, "David Reveman" <reveman@chromium.org> wrote:

> Why not add it to the layer tree at the time of capture and then remove it
> when capture completes?
>
> On Jun 12, 2017 6:05 PM, <domlaskowski@chromium.org> wrote:
>
> On 2017/06/12 21:56:09, reveman wrote:
> > Why does it have to be re-parented? Why can't we instead adjust the
> scale used
> > for capture?
>
> The initial primary display could be removed, in which case we have no
> other
> choice but to reparent.
>
> https://codereview.chromium.org/2934953002/
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-06-12 22:22:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 22:22:28]

Dry run: This issue passed the CQ dry run.

[Dominik Laskowski, 2017-06-12 22:43:25]

On 2017/06/12 22:15:30, reveman wrote:
> Why not add it to the layer tree at the time of capture and then remove it
> when capture completes?
>
> Maybe not even bother to remove it. Just make sure to add it before each
> capture request..

Reparenting is only necessary on display reconfiguration, so removing/adding the
window on every commit is overkill.

[reveman, 2017-06-13 00:06:45]

Ok, I'm convinced that this is ideal. Thanks for explaining. Lgtm with nit

https://codereview.chromium.org/2934953002/diff/1/components/exo/pointer.h
File components/exo/pointer.h (right):

https://codereview.chromium.org/2934953002/diff/1/components/exo/pointer.h#ne...
components/exo/pointer.h:80: void UpdatePointerSurface(Surface* surface);
nit: short comment here for consistency

[Dominik Laskowski, 2017-06-13 17:53:11]

https://codereview.chromium.org/2934953002/diff/1/components/exo/pointer.h
File components/exo/pointer.h (right):

https://codereview.chromium.org/2934953002/diff/1/components/exo/pointer.h#ne...
components/exo/pointer.h:80: void UpdatePointerSurface(Surface* surface);
On 2017/06/13 00:06:45, reveman wrote:
> nit: short comment here for consistency

Done.

[Dominik Laskowski, 2017-06-13 17:54:10]

The CQ bit was checked by domlaskowski@chromium.org

[Dominik Laskowski, 2017-06-13 17:54:10]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2934953002/#ps40001
(title: "Add comment")

[commit-bot: I haz the power, 2017-06-13 17:54:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 18:36:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497376450473100,
"parent_rev": "8f4fa4d9c59560c74bb349f3a16b6981cd85f8ee", "commit_rev":
"f86ddbbc48abb0d8c2ad6ee10a1728ff7e87e00c"}

[commit-bot: I haz the power, 2017-06-13 18:36:13]

Description was changed from

==========
exo: Reparent pointer surface

When the display configuration changes, the pointer surface must be
reparented to the new primary display. A client-side bug previously
forced a surface change on pointer enter, causing the surface to be
reparented to the latest primary display.

BUG=730843
TEST=Verify correct parenting by printing window hierarchy.
==========

to

==========
exo: Reparent pointer surface

When the display configuration changes, the pointer surface must be
reparented to the new primary display. A client-side bug previously
forced a surface change on pointer enter, causing the surface to be
reparented to the latest primary display.

BUG=730843
TEST=Verify correct parenting by printing window hierarchy.

Review-Url: https://codereview.chromium.org/2934953002
Cr-Commit-Position: refs/heads/master@{#479073}
Committed:
https://chromium.googlesource.com/chromium/src/+/f86ddbbc48abb0d8c2ad6ee10a17...
==========

[commit-bot: I haz the power, 2017-06-13 18:36:14]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f86ddbbc48abb0d8c2ad6ee10a17...