Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2934923002:
Uprev CHROMEOS_LKGM to 9641.0.0 (Closed)
DescriptionUprev CHROMEOS_LKGM to 9641.0.0
BUG=none
Review-Url: https://codereview.chromium.org/2934923002
Cr-Commit-Position: refs/heads/master@{#478827}
Committed: https://chromium.googlesource.com/chromium/src/+/c7a69f4049131946f9a507b8fb4ba38d1b335876
Patch Set 1 #
Messages
Total messages: 18 (6 generated)
stevenjb@chromium.org changed reviewers: + achuith@chromium.org, michaelpg@chromium.org, rcui@chromium.org
As near as I can tell, this will update the cros version for simple chrome for developers. The canary/release builders specify --sdk-path and should be unaffected when they run TestSimpleChromeWorkflow. The cq/paladin builders do not appear to run TestSimpleChromeWorkflow.
lgtm. Can you run this by Aviv to make sure this doesn't break something?
On 2017/06/12 21:44:47, achuithb wrote: > lgtm. > > Can you run this by Aviv to make sure this doesn't break something? I've launched the 3 simple chrome trybot builders - we should wait for their output, and let's also verify that they use 9641.0.0 for their run.
On 2017/06/12 21:46:19, achuithb wrote: > On 2017/06/12 21:44:47, achuithb wrote: > > lgtm. > > > > Can you run this by Aviv to make sure this doesn't break something? > > I've launched the 3 simple chrome trybot builders - we should wait for their > output, and let's also verify that they use 9641.0.0 for their run. Thanks, SGTM!
stevenjb@chromium.org changed reviewers: + akeshet@chromium.org
+akeshet@
On 2017/06/12 21:46:19, achuithb wrote: > On 2017/06/12 21:44:47, achuithb wrote: > > lgtm. > > > > Can you run this by Aviv to make sure this doesn't break something? > > I've launched the 3 simple chrome trybot builders - we should wait for their > output, and let's also verify that they use 9641.0.0 for their run. Hmm, doesn't look like the builder outputs the version it uses without debug logging :/ Or I couldn't find it
On 2017/06/12 21:54:01, achuithb wrote: > On 2017/06/12 21:46:19, achuithb wrote: > > On 2017/06/12 21:44:47, achuithb wrote: > > > lgtm. > > > > > > Can you run this by Aviv to make sure this doesn't break something? > > > > I've launched the 3 simple chrome trybot builders - we should wait for their > > output, and let's also verify that they use 9641.0.0 for their run. > > Hmm, doesn't look like the builder outputs the version it uses without debug > logging :/ Or I couldn't find it Never mind, the analyze step outputs the version of the toolchain it downloads: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux... 9641.0.0
Great, cheers! On Mon, Jun 12, 2017 at 2:56 PM, <achuith@chromium.org> wrote: > On 2017/06/12 21:54:01, achuithb wrote: > > On 2017/06/12 21:46:19, achuithb wrote: > > > On 2017/06/12 21:44:47, achuithb wrote: > > > > lgtm. > > > > > > > > Can you run this by Aviv to make sure this doesn't break something? > > > > > > I've launched the 3 simple chrome trybot builders - we should wait for > their > > > output, and let's also verify that they use 9641.0.0 for their run. > > > > Hmm, doesn't look like the builder outputs the version it uses without > debug > > logging :/ Or I couldn't find it > > Never mind, the analyze step outputs the version of the toolchain it > downloads: > https://luci-logdog.appspot.com/v/?s=chromium%2Fbb% > 2Ftryserver.chromium.linux%2Fchromeos_amd64-generic_ > chromium_compile_only_ng%2F358676%2F%2B%2Frecipes% > 2Fsteps%2Fanalyze%2F0%2Fstdout > > 9641.0.0 > > https://codereview.chromium.org/2934923002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
lgtm
akeshet@google.com changed reviewers: + akeshet@google.com
lgtm lgtm, I don't know of anything this would break
The CQ bit was checked by stevenjb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1497311236151560, "parent_rev":
"c43f20626116a43516ae3568cfb1aa30b0ba6dd8", "commit_rev":
"c7a69f4049131946f9a507b8fb4ba38d1b335876"}
Message was sent while issue was closed.
Description was changed from ========== Uprev CHROMEOS_LKGM to 9641.0.0 BUG=none ========== to ========== Uprev CHROMEOS_LKGM to 9641.0.0 BUG=none Review-Url: https://codereview.chromium.org/2934923002 Cr-Commit-Position: refs/heads/master@{#478827} Committed: https://chromium.googlesource.com/chromium/src/+/c7a69f4049131946f9a507b8fb4b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c7a69f4049131946f9a507b8fb4b... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
