Chromium Code Reviews
DescriptionRe-add content-independent marker tests to InputMethodControllerTest
In https://codereview.chromium.org/2895353003, I split the behavior for
modifying DocumentMarkers in response to text edits into two versions:
content-dependent (the historical behavior), and content-independent (the
behavior I need to implement support for Android SuggestionSpans, which I had
previously changed all DocumentMarkers to use before the mentioned CL). At the
time of this CL, the only marker type using the content-independent behavior was
Composition, and Composition markers are cleared by many text-editing
operations, so I changed all the DocumentMarker-shifting-related test cases in
InputMethodControllerTest to test the content-dependent behavior (and removed a
few tests that were no longer applicable).
In this CL, I'm re-adding the tests I removed and adding tests for the content
independent marker-shifting behavior (using the ActiveSuggestion marker type
I've added) to complement the tests for the content-dependent behavior.
BUG=672259
Review-Url: https://codereview.chromium.org/2934913002
Cr-Commit-Position: refs/heads/master@{#478913}
Committed: https://chromium.googlesource.com/chromium/src/+/a01ec54e907dcda55f339330da7c05149295131b
Patch Set 1 #Patch Set 2 : Re-add missing test, fix mixed-up test case names #Messages
Total messages: 13 (8 generated)
|