Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2934913002: Re-add content-independent marker tests to InputMethodControllerTest (Closed)

Created:
3 years, 6 months ago by rlanday
Modified:
3 years, 6 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-add content-independent marker tests to InputMethodControllerTest In https://codereview.chromium.org/2895353003, I split the behavior for modifying DocumentMarkers in response to text edits into two versions: content-dependent (the historical behavior), and content-independent (the behavior I need to implement support for Android SuggestionSpans, which I had previously changed all DocumentMarkers to use before the mentioned CL). At the time of this CL, the only marker type using the content-independent behavior was Composition, and Composition markers are cleared by many text-editing operations, so I changed all the DocumentMarker-shifting-related test cases in InputMethodControllerTest to test the content-dependent behavior (and removed a few tests that were no longer applicable). In this CL, I'm re-adding the tests I removed and adding tests for the content independent marker-shifting behavior (using the ActiveSuggestion marker type I've added) to complement the tests for the content-dependent behavior. BUG=672259 Review-Url: https://codereview.chromium.org/2934913002 Cr-Commit-Position: refs/heads/master@{#478913} Committed: https://chromium.googlesource.com/chromium/src/+/a01ec54e907dcda55f339330da7c05149295131b

Patch Set 1 #

Patch Set 2 : Re-add missing test, fix mixed-up test case names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+468 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 1 13 chunks +468 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
rlanday
3 years, 6 months ago (2017-06-12 21:12:41 UTC) #3
rlanday
3 years, 6 months ago (2017-06-12 21:12:44 UTC) #4
yosin_UTC9
lgtm
3 years, 6 months ago (2017-06-13 06:17:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2934913002/20001
3 years, 6 months ago (2017-06-13 06:17:25 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 06:20:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a01ec54e907dcda55f339330da7c...

Powered by Google App Engine
This is Rietveld 408576698