Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2934883004: Rewrite editing/inserting/insert-composition-whitespace.html to utilize assert_selection() (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite editing/inserting/insert-composition-whitespace.html to utilize assert_selection() This patch changes "editing/inserting/insert-composition-whitespace.html" to utilize |assert_selection()| for ease of maintaining test case. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/527421: Fix contentEditable treatment of double spaces BUG=731756 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2934883004 Cr-Commit-Position: refs/heads/master@{#479316} Committed: https://chromium.googlesource.com/chromium/src/+/dacd0365e96783bfccbcb9dbc4cff060e15d3fec

Patch Set 1 : 2017-06-14T13:56:20 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -178 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/inserting/insert-composition-whitespace.html View 1 chunk +65 lines, -83 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-composition-whitespace-expected.txt View 1 chunk +0 lines, -94 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-14 06:27:18 UTC) #7
yoichio
lgtm
3 years, 6 months ago (2017-06-14 07:16:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2934883004/1
3 years, 6 months ago (2017-06-14 07:20:25 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 07:26:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dacd0365e96783bfccbcb9dbc4cf...

Powered by Google App Engine
This is Rietveld 408576698