Snap non toplevel dialog windows to pixel boundary.

Snap non toplevel dialog windows to pixel boundary.

BUG=731309
TEST=manual. Start chrome with --force-device-scale-factor=1.6 and make sure javascript dialog is crisp.

Review-Url: https://codereview.chromium.org/2934883003
Cr-Commit-Position: refs/heads/master@{#485032}
Committed: https://chromium.googlesource.com/chromium/src/+/4d312315c85cb0a75cdb36f236d84bccf88392e6

[oshima, 2017-06-13 07:50:51]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 07:51:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 09:10:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 09:10:32]

Dry run: This issue passed the CQ dry run.

[oshima, 2017-06-13 19:29:55]

Description was changed from

==========
Snap non toplevel dialog windows to pixel boundary.

BUG=731309
TEST=manual. See bug for repro step.
==========

to

==========
Snap non toplevel dialog windows to pixel boundary.

BUG=731309
TEST=manual. Start chrome with --force-device-scale-factor=1.6 and make sure
javascript dialog is crisp.
==========

[oshima, 2017-06-13 19:29:56]

oshima@chromium.org changed reviewers:
+ gbillock@chromium.org

[oshima, 2017-06-16 14:47:16]

ping?

[oshima, 2017-06-27 16:33:03]

friendly ping?

[oshima, 2017-07-05 18:22:10]

oshima@chromium.org changed reviewers:
+ msw@chromium.org
- gbillock@chromium.org

[oshima, 2017-07-05 18:22:10]

msw@, can you review this?

[msw, 2017-07-05 20:16:42]

lgtm with a nit

https://codereview.chromium.org/2934883003/diff/1/components/constrained_wind...
File components/constrained_window/constrained_window_views.cc (right):

https://codereview.chromium.org/2934883003/diff/1/components/constrained_wind...
components/constrained_window/constrained_window_views.cc:140: aura::Window*
window = widget->GetNativeWindow();
nit: use gfx::NativeView and GetNativeView or inline GetNativeView.

[oshima, 2017-07-07 18:04:58]

oshima@chromium.org changed reviewers:
+ piman@chromium.org

[oshima, 2017-07-07 18:11:30]

piman@ for adding ui/compositor in DEPS

https://codereview.chromium.org/2934883003/diff/1/components/constrained_wind...
File components/constrained_window/constrained_window_views.cc (right):

https://codereview.chromium.org/2934883003/diff/1/components/constrained_wind...
components/constrained_window/constrained_window_views.cc:140: aura::Window*
window = widget->GetNativeWindow();
On 2017/07/05 20:16:42, msw - vacation july 7 wrote:
> nit: use gfx::NativeView and GetNativeView or inline GetNativeView.

Done

[piman, 2017-07-07 18:25:21]

lgtm

[oshima, 2017-07-07 19:26:49]

The CQ bit was checked by oshima@chromium.org

[oshima, 2017-07-07 19:26:50]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2934883003/#ps20001
(title: "addressed comment")

[commit-bot: I haz the power, 2017-07-07 19:27:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 20:36:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499455609511560,
"parent_rev": "77dda4d03d4eef979c3d45715df4364e1182683b", "commit_rev":
"fec499560935a15f112e201634ad33f65236e2f8"}

[commit-bot: I haz the power, 2017-07-07 20:37:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499455609511560,
"parent_rev": "0b54ae5cc48704bc3ab1ff0c5fa6d5155c3c9eef", "commit_rev":
"4d312315c85cb0a75cdb36f236d84bccf88392e6"}

[commit-bot: I haz the power, 2017-07-07 20:37:39]

Description was changed from

==========
Snap non toplevel dialog windows to pixel boundary.

BUG=731309
TEST=manual. Start chrome with --force-device-scale-factor=1.6 and make sure
javascript dialog is crisp.
==========

to

==========
Snap non toplevel dialog windows to pixel boundary.

BUG=731309
TEST=manual. Start chrome with --force-device-scale-factor=1.6 and make sure
javascript dialog is crisp.

Review-Url: https://codereview.chromium.org/2934883003
Cr-Commit-Position: refs/heads/master@{#485032}
Committed:
https://chromium.googlesource.com/chromium/src/+/4d312315c85cb0a75cdb36f236d8...
==========

[commit-bot: I haz the power, 2017-07-07 20:37:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4d312315c85cb0a75cdb36f236d8...