cros: add new search box hint text for launcher

cros: add new search box hint text for launcher

R=xiyuan@chromium.org
BUG=730037
TEST=tested that enabling the new launcher with
--enable-features=EnableFullscreenAppList, search box will show "Search
your Chromebook, apps, web..." hint text; disabling the flag falls to
current behavior.

Review-Url: https://codereview.chromium.org/2934883002
Cr-Commit-Position: refs/heads/master@{#478815}
Committed: https://chromium.googlesource.com/chromium/src/+/6c84a944f1ac480f9afd1ad93225499c40ddbf0b

[Qiang(Joe) Xu, 2017-06-12 19:04:58]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[Qiang(Joe) Xu, 2017-06-12 19:05:09]

Hi xiyuan, PTAL

[commit-bot: I haz the power, 2017-06-12 19:05:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2017-06-12 19:24:55]

Mostly nits

https://codereview.chromium.org/2934883002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2934883002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:11147: Search your Chromebook, apps, web...
Usually we use a place holder for "Chromebook" and replace it with what
ash::GetChromeOSDeviceName() returns.

e.g.

https://cs.chromium.org/chromium/src/chrome/browser/chromeos/arc/arc_auth_not...

https://codereview.chromium.org/2934883002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/search/search_resource_manager.h (right):

https://codereview.chromium.org/2934883002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/search/search_resource_manager.h:34: bool
fullscreen_app_list_enabled_ = false;
nit: bool -> const bool

[commit-bot: I haz the power, 2017-06-12 20:31:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 20:31:39]

Dry run: This issue passed the CQ dry run.

[Qiang(Joe) Xu, 2017-06-12 21:45:31]

Updated, PTAL thanks

https://codereview.chromium.org/2934883002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2934883002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:11147: Search your Chromebook, apps, web...
On 2017/06/12 19:24:55, xiyuan wrote:
> Usually we use a place holder for "Chromebook" and replace it with what
> ash::GetChromeOSDeviceName() returns.
> 
> e.g.
> 
>
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/arc/arc_auth_not...

done

https://codereview.chromium.org/2934883002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/search/search_resource_manager.h (right):

https://codereview.chromium.org/2934883002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/search/search_resource_manager.h:34: bool
fullscreen_app_list_enabled_ = false;
On 2017/06/12 19:24:55, xiyuan wrote:
> nit: bool -> const bool

felt can just remove this.

[xiyuan, 2017-06-12 21:53:25]

lgtm

[Qiang(Joe) Xu, 2017-06-12 21:55:00]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2017-06-12 21:55:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 23:18:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497304500414340,
"parent_rev": "e4208d105f75a14f9719ae35c19d7104f08a5f0b", "commit_rev":
"6c84a944f1ac480f9afd1ad93225499c40ddbf0b"}

[commit-bot: I haz the power, 2017-06-12 23:19:02]

Description was changed from

==========
cros: add new search box hint text for launcher

R=xiyuan@chromium.org
BUG=730037
TEST=tested that enabling the new launcher with
--enable-features=EnableFullscreenAppList, search box will show "Search
your Chromebook, apps, web..." hint text; disabling the flag falls to
current behavior.
==========

to

==========
cros: add new search box hint text for launcher

R=xiyuan@chromium.org
BUG=730037
TEST=tested that enabling the new launcher with
--enable-features=EnableFullscreenAppList, search box will show "Search
your Chromebook, apps, web..." hint text; disabling the flag falls to
current behavior.

Review-Url: https://codereview.chromium.org/2934883002
Cr-Commit-Position: refs/heads/master@{#478815}
Committed:
https://chromium.googlesource.com/chromium/src/+/6c84a944f1ac480f9afd1ad93225...
==========

[commit-bot: I haz the power, 2017-06-12 23:19:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6c84a944f1ac480f9afd1ad93225...