Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2934873002: Omnibox UI Experiments: Add border and shadow to narrow dropdown in Mac. (Closed)

Created:
3 years, 6 months ago by tommycli
Modified:
3 years, 6 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, jdonnelly+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox UI Experiments: Add border and shadow to narrow dropdown in Mac. Adds the border and shadow to the narrow-mode dropdown in Mac. This does not implement the rounded corners yet, as that will be a lot more work. That's still forthcoming. BUG=728844 Review-Url: https://codereview.chromium.org/2934873002 Cr-Commit-Position: refs/heads/master@{#480989} Committed: https://chromium.googlesource.com/chromium/src/+/183f3046f02992f1390d59a357de419689826c2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm View 2 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tommycli
groby: PTAL, this is the simple version without rounded corners to get something "out there". ...
3 years, 6 months ago (2017-06-12 18:21:48 UTC) #4
groby-ooo-7-16
lgtm
3 years, 6 months ago (2017-06-20 21:16:31 UTC) #7
tommycli
On 2017/06/20 21:16:31, groby wrote: > lgtm thanks!
3 years, 6 months ago (2017-06-20 21:42:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2934873002/1
3 years, 6 months ago (2017-06-20 21:43:39 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 22:15:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/183f3046f02992f1390d59a357de...

Powered by Google App Engine
This is Rietveld 408576698