[Refactor] Use correct viewport style in Android tests

[Refactor] Use correct viewport style in Android tests

SetViewportStyle(kMobile) gives tests default Android viewport style
setting. This makes Blink fallback to the 980px layout width in the
absence of a viewport meta tag.

BUG=

Review-Url: https://codereview.chromium.org/2934853002
Cr-Commit-Position: refs/heads/master@{#478673}
Committed: https://chromium.googlesource.com/chromium/src/+/7f09ece330fd144421f416d473e3131f57b6050f

[chaopeng, 2017-06-12 15:50:49]

chaopeng@chromium.org changed reviewers:
+ bokan@chromium.org

[chaopeng, 2017-06-12 15:50:49]

PTAL. Thank you.

[chaopeng, 2017-06-12 15:55:43]

The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 15:56:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bokan, 2017-06-12 16:06:11]

The subject line should be <50 chars. Something like "Use correct viewport style
in Android tests".

Also: "SetViewportStyle(kMobile) gives tests default viewport style setting"

should be "SetViewportStyle(kMobile) gives tests default Android viewport style
setting". Would be worth noting that this makes Blink fallback to the 980px
layout width in the absence of a viewport meta tag.

https://codereview.chromium.org/2934853002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/2934853002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/WebFrameTest.cpp:1088: void
EnableViewportSettings(WebSettings* settings) {
This is identical to ConfigureAndroid, remove it and replace with
ConfigureAndroid.

https://codereview.chromium.org/2934853002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/WebFrameTest.cpp:10304:
ScrollUpdate(&web_view_helper, 0, -250);
Eh, why did this change? Didn't we see this work with 150 when I was at your
machine?

[chaopeng, 2017-06-12 16:18:47]

Description was changed from

==========
[Refactor] Move SetViewportStyle to ConfigureAndroid and EnableViewportSettings
in WebViewTest

SetViewportStyle(kMobile) gives tests default viewport style setting. Should set
for all settings using ConfigureAndroid and EnableViewportSettings.

BUG=
==========

to

==========
[Refactor] Use correct viewport style in Android tests

SetViewportStyle(kMobile) gives tests default Android viewport style
setting. Would be worth noting that this makes Blink fallback to the
980px layout width in the absence of a viewport meta tag.

BUG=
==========

[chaopeng, 2017-06-12 16:22:23]

The CQ bit was unchecked by chaopeng@chromium.org

[chaopeng, 2017-06-12 16:29:09]

The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run

[chaopeng, 2017-06-12 16:29:21]

Updated. PTAL. Thank you.

https://codereview.chromium.org/2934853002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/2934853002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/WebFrameTest.cpp:10304:
ScrollUpdate(&web_view_helper, 0, -250);
On 2017/06/12 16:06:11, bokan wrote:
> Eh, why did this change? Didn't we see this work with 150 when I was at your
> machine?

Forgot revert this one.

[commit-bot: I haz the power, 2017-06-12 16:29:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bokan, 2017-06-12 17:15:43]

Description was changed from

==========
[Refactor] Use correct viewport style in Android tests

SetViewportStyle(kMobile) gives tests default Android viewport style
setting. Would be worth noting that this makes Blink fallback to the
980px layout width in the absence of a viewport meta tag.

BUG=
==========

to

==========
[Refactor] Use correct viewport style in Android tests

SetViewportStyle(kMobile) gives tests default Android viewport style
setting. This makes Blink fallback to the 980px layout width in the
absence of a viewport meta tag.

BUG=
==========

[bokan, 2017-06-12 17:16:24]

thanks, lgtm

[chaopeng, 2017-06-12 17:23:19]

The CQ bit was unchecked by chaopeng@chromium.org

[chaopeng, 2017-06-12 17:23:23]

The CQ bit was checked by chaopeng@chromium.org

[commit-bot: I haz the power, 2017-06-12 17:23:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 17:52:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497288203093930,
"parent_rev": "fc5a62447efda4feda47694477b17ff7296a8454", "commit_rev":
"7f09ece330fd144421f416d473e3131f57b6050f"}

[commit-bot: I haz the power, 2017-06-12 17:52:15]

Description was changed from

==========
[Refactor] Use correct viewport style in Android tests

SetViewportStyle(kMobile) gives tests default Android viewport style
setting. This makes Blink fallback to the 980px layout width in the
absence of a viewport meta tag.

BUG=
==========

to

==========
[Refactor] Use correct viewport style in Android tests

SetViewportStyle(kMobile) gives tests default Android viewport style
setting. This makes Blink fallback to the 980px layout width in the
absence of a viewport meta tag.

BUG=

Review-Url: https://codereview.chromium.org/2934853002
Cr-Commit-Position: refs/heads/master@{#478673}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f09ece330fd144421f416d473e3...
==========

[commit-bot: I haz the power, 2017-06-12 17:52:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7f09ece330fd144421f416d473e3...