Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2934843002: Adds signin provider APIs that don't return scoped_nsobjects. (Closed)

Created:
3 years, 6 months ago by stkhapugin
Modified:
3 years, 6 months ago
Reviewers:
msarda
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds signin provider APIs that don't return scoped_nsobjects. Returning scoped_nsobjects is against the philosophy of autoreleased objects being passed around. Refactoring methods and functions vending scoped_nsobjects allows for a cleaner transition to ARC later. This is CL 1/5. BUG=None TEST=None Review-Url: https://codereview.chromium.org/2934843002 Cr-Commit-Position: refs/heads/master@{#478650} Committed: https://chromium.googlesource.com/chromium/src/+/2417d00a4e397fffcb5a76ff670fc8bb52819c1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3 lines) Patch
M ios/public/provider/chrome/browser/signin/chrome_identity_service.h View 1 chunk +22 lines, -3 lines 0 comments Download
M ios/public/provider/chrome/browser/signin/chrome_identity_service.mm View 1 chunk +20 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
stkhapugin
PTAL
3 years, 6 months ago (2017-06-12 15:31:33 UTC) #2
msarda
lgtm
3 years, 6 months ago (2017-06-12 16:03:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2934843002/1
3 years, 6 months ago (2017-06-12 16:04:17 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 16:22:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2417d00a4e397fffcb5a76ff670f...

Powered by Google App Engine
This is Rietveld 408576698