Handle named mixin application in emitter

Handle named mixin application in emitter

Fixes regression in language/regress_18713_test with --csp

Closes #29844
Closes #29843


Committed: https://github.com/dart-lang/sdk/commit/d109fad7f33269ccf05a64eaa8719913ecffa02e

Reverted: https://github.com/dart-lang/sdk/commit/d8783acfb3abbf863a1d2d9630c716cff801df25

Landed through https://codereview.chromium.org/2936063002/

[Johnni Winther, 2017-06-12 09:40:50]

Description was changed from

==========
# Enter a description of the change.
Handle named mixin application in emitter

Fixes regression in language/regress_18713_test with --csp
==========

to

==========
Handle named mixin application in emitter

Fixes regression in language/regress_18713_test with --csp
==========

[Johnni Winther, 2017-06-12 09:41:07]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Johnni Winther, 2017-06-12 09:41:08]

TBR

[Johnni Winther, 2017-06-12 09:49:35]

Description was changed from

==========
Handle named mixin application in emitter

Fixes regression in language/regress_18713_test with --csp
==========

to

==========
Handle named mixin application in emitter

Fixes regression in language/regress_18713_test with --csp

Committed:
https://github.com/dart-lang/sdk/commit/d109fad7f33269ccf05a64eaa8719913ecffa02e
==========

[Johnni Winther, 2017-06-12 09:49:37]

Committed patchset #2 (id:20001) manually as
d109fad7f33269ccf05a64eaa8719913ecffa02e (presubmit successful).

[ahe, 2017-06-12 12:25:23]

ahe@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-06-12 12:25:23]

I reverted this and marked the test as failing
(https://codereview.chromium.org/2933093002). I did so because this CL caused
more errors in non-CSP that I couldn't immediately understand, so I figured
reverting this CL would be preferable over reverting all the other CLs Johnni
landed this morning.

[Johnni Winther, 2017-06-13 07:19:38]

Description was changed from

==========
Handle named mixin application in emitter

Fixes regression in language/regress_18713_test with --csp

Committed:
https://github.com/dart-lang/sdk/commit/d109fad7f33269ccf05a64eaa8719913ecffa02e
==========

to

==========
Handle named mixin application in emitter

Fixes regression in language/regress_18713_test with --csp

Committed:
https://github.com/dart-lang/sdk/commit/d109fad7f33269ccf05a64eaa8719913ecffa02e

Reverted:
https://github.com/dart-lang/sdk/commit/d8783acfb3abbf863a1d2d9630c716cff801df25
==========

[Johnni Winther, 2017-06-13 09:17:07]

Description was changed from

==========
Handle named mixin application in emitter

Fixes regression in language/regress_18713_test with --csp

Committed:
https://github.com/dart-lang/sdk/commit/d109fad7f33269ccf05a64eaa8719913ecffa02e

Reverted:
https://github.com/dart-lang/sdk/commit/d8783acfb3abbf863a1d2d9630c716cff801df25
==========

to

==========
Handle named mixin application in emitter

Fixes regression in language/regress_18713_test with --csp

Closes #29844
Closes #29843


Committed:
https://github.com/dart-lang/sdk/commit/d109fad7f33269ccf05a64eaa8719913ecffa02e

Reverted:
https://github.com/dart-lang/sdk/commit/d8783acfb3abbf863a1d2d9630c716cff801df25
==========

[Johnni Winther, 2017-06-13 09:17:35]

johnniwinther@google.com changed reviewers:
+ efortuna@google.com
- ahe@google.com

[Johnni Winther, 2017-06-13 09:17:36]

PTAL

[Emily Fortuna, 2017-06-13 17:22:51]

lgtm

https://codereview.chromium.org/2934783002/diff/40001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
(right):

https://codereview.chromium.org/2934783002/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart:242: "No
class for effective mixin ${effectiveMixinClass} on $cls."));
nit: >80 char here

[Emily Fortuna, 2017-06-13 21:27:34]

On 2017/06/13 17:22:51, Emily Fortuna wrote:
> lgtm
> 
>
https://codereview.chromium.org/2934783002/diff/40001/pkg/compiler/lib/src/js...
> File pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
> (right):
> 
>
https://codereview.chromium.org/2934783002/diff/40001/pkg/compiler/lib/src/js...
> pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart:242: "No
> class for effective mixin ${effectiveMixinClass} on $cls."));
> nit: >80 char here

Note, I ended up having to submit a version of this CL myself because it was
blocking a Google3 dart update.

[Johnni Winther, 2017-06-14 07:42:16]

On 2017/06/13 21:27:34, Emily Fortuna wrote:
> On 2017/06/13 17:22:51, Emily Fortuna wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/2934783002/diff/40001/pkg/compiler/lib/src/js...
> > File pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
> > (right):
> > 
> >
>
https://codereview.chromium.org/2934783002/diff/40001/pkg/compiler/lib/src/js...
> > pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart:242:
"No
> > class for effective mixin ${effectiveMixinClass} on $cls."));
> > nit: >80 char here
> 
> Note, I ended up having to submit a version of this CL myself because it was
> blocking a Google3 dart update.

Good!

[Johnni Winther, 2017-06-14 07:48:09]

Description was changed from

==========
Handle named mixin application in emitter

Fixes regression in language/regress_18713_test with --csp

Closes #29844
Closes #29843


Committed:
https://github.com/dart-lang/sdk/commit/d109fad7f33269ccf05a64eaa8719913ecffa02e

Reverted:
https://github.com/dart-lang/sdk/commit/d8783acfb3abbf863a1d2d9630c716cff801df25
==========

to

==========
Handle named mixin application in emitter

Fixes regression in language/regress_18713_test with --csp

Closes #29844
Closes #29843


Committed:
https://github.com/dart-lang/sdk/commit/d109fad7f33269ccf05a64eaa8719913ecffa02e

Reverted:
https://github.com/dart-lang/sdk/commit/d8783acfb3abbf863a1d2d9630c716cff801df25

Landed through https://codereview.chromium.org/2936063002/
==========