Issue 2933093002: Revert "Handle named mixin application in emitter"

Issue 2933093002: Revert "Handle named mixin application in emitter" (Closed)

Created:
3 years, 6 months ago by ahe

Modified:
3 years, 6 months ago

Reviewers:
erikcorry, Johnni Winther, Bill Hesse

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "Handle named mixin application in emitter" This reverts commit d109fad7f33269ccf05a64eaa8719913ecffa02e. Also, update status and ignore strong mode warning. R=erikcorry@google.com Committed: https://github.com/dart-lang/sdk/commit/d8783acfb3abbf863a1d2d9630c716cff801df25

Patch Set 2 : Add bug numbers. #

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -26 lines)			Patch
M	pkg/compiler/lib/src/common_elements.dart	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/kernel/element_map_impl.dart	View		5 chunks	+0 lines, -16 lines	0 comments	Download
M	pkg/compiler/lib/src/kernel/task.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/resolution_strategy.dart	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

erikcorry

lgtm, thanks for jumping in on this https://codereview.chromium.org/2933093002/diff/1/pkg/compiler/lib/src/kernel/task.dart File pkg/compiler/lib/src/kernel/task.dart (right): https://codereview.chromium.org/2933093002/diff/1/pkg/compiler/lib/src/kernel/task.dart#newcode42 pkg/compiler/lib/src/kernel/task.dart:42: // ignore: ...

3 years, 6 months ago (2017-06-12 12:15:46 UTC) #3

ahe

Thank you, Erik! https://codereview.chromium.org/2933093002/diff/1/pkg/compiler/lib/src/kernel/task.dart File pkg/compiler/lib/src/kernel/task.dart (right): https://codereview.chromium.org/2933093002/diff/1/pkg/compiler/lib/src/kernel/task.dart#newcode42 pkg/compiler/lib/src/kernel/task.dart:42: // ignore: INVALID_ASSIGNMENT On 2017/06/12 12:15:46, ...

3 years, 6 months ago (2017-06-12 12:21:20 UTC) #4

ahe

Committed patchset #2 (id:20001) manually as d8783acfb3abbf863a1d2d9630c716cff801df25.

3 years, 6 months ago (2017-06-12 12:21:40 UTC) #6

Message was sent while issue was closed.

LGTM, thanks!

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages