Unify implementation of LeftPositionOf() and RightPositionOf()

Utilize one template to implement LeftPositionOf() and RightPositionOf()

This patch introduces |TraverseAlgorhtim()| and |TraverseInternalAlgorhtim()|
to unify |LeftPositoinOf()| and |RightPositionOf()| implementations since
these functions use identical algorithm except for except for traverse direction
to avoid source code duplication for improving code health.

BUG=707656
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2934773002
Cr-Commit-Position: refs/heads/master@{#478933}
Committed: https://chromium.googlesource.com/chromium/src/+/3de8b2e022a8448fec77e19e47aa2d3dd769508f

[yosin_UTC9, 2017-06-12 09:38:08]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 09:38:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-12 09:56:51]

Description was changed from

==========
2017-06-12T18:35:38

BUG=707656

2017-06-12T18:35:07
==========

to

==========
Utilize one template to implement LeftPositionOf() and RightPositionOf()

This patch introduces |TraverseAlgorhtim()| and |TraverseInternalAlgorhtim()|
to unify |LeftPositoinOf()| and |RightPositionOf()| implementations since
these functions use identical algorithm except for except for traverse direction
to reduce source code for improving code health.

BUG=707656
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-06-12 09:57:16]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 09:57:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-12 09:58:00]

Patchset #1 (id:1) has been deleted

[yosin_UTC9, 2017-06-12 09:58:32]

Description was changed from

==========
Utilize one template to implement LeftPositionOf() and RightPositionOf()

This patch introduces |TraverseAlgorhtim()| and |TraverseInternalAlgorhtim()|
to unify |LeftPositoinOf()| and |RightPositionOf()| implementations since
these functions use identical algorithm except for except for traverse direction
to reduce source code for improving code health.

BUG=707656
TEST=n/a; no behavior changes
==========

to

==========
Utilize one template to implement LeftPositionOf() and RightPositionOf()

This patch introduces |TraverseAlgorhtim()| and |TraverseInternalAlgorhtim()|
to unify |LeftPositoinOf()| and |RightPositionOf()| implementations since
these functions use identical algorithm except for except for traverse direction
to avoid source code duplication for improving code health.

BUG=707656
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-06-12 09:58:44]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-06-12 09:58:45]

PTAL

[commit-bot: I haz the power, 2017-06-12 11:58:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 11:58:52]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-06-12 18:28:15]

lgtm with a nit.

https://codereview.chromium.org/2934773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/SelectionModifierCharacter.cpp
(right):

https://codereview.chromium.org/2934773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/SelectionModifierCharacter.cpp:186: //
TODO(yosin): We should rename local variables in
nit: And also comments.

https://codereview.chromium.org/2934773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/SelectionModifierCharacter.cpp:243: //
Overshot to the left.
Like this.

[yosin_UTC9, 2017-06-13 06:44:46]

Thanks for reviewing!
Committing...

https://codereview.chromium.org/2934773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/SelectionModifierCharacter.cpp
(right):

https://codereview.chromium.org/2934773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/SelectionModifierCharacter.cpp:186: //
TODO(yosin): We should rename local variables in
On 2017/06/12 at 18:28:15, Xiaocheng wrote:
> nit: And also comments.

Done.

https://codereview.chromium.org/2934773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/SelectionModifierCharacter.cpp:243: //
Overshot to the left.
On 2017/06/12 at 18:28:15, Xiaocheng wrote:
> Like this.

Good catch!

[yosin_UTC9, 2017-06-13 06:44:50]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-06-13 06:44:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2934773002/#ps40001
(title: "2017-06-13T15:43:11")

[commit-bot: I haz the power, 2017-06-13 06:44:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 08:21:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497336290903510,
"parent_rev": "b3c5fc7190a4cf828bf543444d1d76a44067e2a0", "commit_rev":
"3de8b2e022a8448fec77e19e47aa2d3dd769508f"}

[commit-bot: I haz the power, 2017-06-13 08:21:23]

Description was changed from

==========
Utilize one template to implement LeftPositionOf() and RightPositionOf()

This patch introduces |TraverseAlgorhtim()| and |TraverseInternalAlgorhtim()|
to unify |LeftPositoinOf()| and |RightPositionOf()| implementations since
these functions use identical algorithm except for except for traverse direction
to avoid source code duplication for improving code health.

BUG=707656
TEST=n/a; no behavior changes
==========

to

==========
Utilize one template to implement LeftPositionOf() and RightPositionOf()

This patch introduces |TraverseAlgorhtim()| and |TraverseInternalAlgorhtim()|
to unify |LeftPositoinOf()| and |RightPositionOf()| implementations since
these functions use identical algorithm except for except for traverse direction
to avoid source code duplication for improving code health.

BUG=707656
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2934773002
Cr-Commit-Position: refs/heads/master@{#478933}
Committed:
https://chromium.googlesource.com/chromium/src/+/3de8b2e022a8448fec77e19e47aa...
==========

[commit-bot: I haz the power, 2017-06-13 08:21:24]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3de8b2e022a8448fec77e19e47aa...