Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: services/ui/gpu/gpu_service.cc

Issue 2934733002: Workaround for Intel 6xxx clear to 0/1 bug (Closed)
Patch Set: fix try-bot error Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gpu/config/gpu_driver_bug_list.json ('K') | « gpu/ipc/service/gpu_init.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/gpu/gpu_service.cc
diff --git a/services/ui/gpu/gpu_service.cc b/services/ui/gpu/gpu_service.cc
index 0330a13c350e1b7dbd0cd64c058bd08bb9ccfcd6..ad5320e0e6c71fbfe01d99c2eab64575459acdb6 100644
--- a/services/ui/gpu/gpu_service.cc
+++ b/services/ui/gpu/gpu_service.cc
@@ -284,31 +284,33 @@ void GpuService::RequestCompleteGpuInfo(
#if defined(OS_MACOSX)
void GpuService::UpdateGpuInfoPlatform() {
- DCHECK(main_runner_->BelongsToCurrentThread());
- // gpu::CollectContextGraphicsInfo() is already called during gpu process
- // initialization (see GpuInit::InitializeAndStartSandbox()) on non-mac
- // platforms, and during in-browser gpu thread initialization on all platforms
- // (See InProcessGpuThread::Init()).
- if (in_host_process_)
- return;
-
- DCHECK_EQ(gpu::kCollectInfoNone, gpu_info_.context_info_state);
- gpu::CollectInfoResult result = gpu::CollectContextGraphicsInfo(&gpu_info_);
- switch (result) {
- case gpu::kCollectInfoFatalFailure:
- LOG(ERROR) << "gpu::CollectGraphicsInfo failed (fatal).";
- // TODO(piman): can we signal overall failure?
- break;
- case gpu::kCollectInfoNonFatalFailure:
- DVLOG(1) << "gpu::CollectGraphicsInfo failed (non-fatal).";
- break;
- case gpu::kCollectInfoNone:
- NOTREACHED();
- break;
- case gpu::kCollectInfoSuccess:
- break;
+ if (gpu_info_.gpu.vendor_id == 0x10de) { // NVIDIA
Zhenyao Mo 2017/06/13 19:01:24 See my comment in the workaround file. Let's not
jiajia.qin 2017/06/14 08:18:21 Acknowledged.
+ DCHECK(main_runner_->BelongsToCurrentThread());
+ // gpu::CollectContextGraphicsInfo() is already called during gpu process
+ // initialization (see GpuInit::InitializeAndStartSandbox()) on
+ // non-nvidia-mac platforms, and during in-browser gpu thread initialization
+ // on all platforms (See InProcessGpuThread::Init()).
+ if (in_host_process_)
+ return;
+
+ DCHECK_EQ(gpu::kCollectInfoNone, gpu_info_.context_info_state);
+ gpu::CollectInfoResult result = gpu::CollectContextGraphicsInfo(&gpu_info_);
+ switch (result) {
+ case gpu::kCollectInfoFatalFailure:
+ LOG(ERROR) << "gpu::CollectGraphicsInfo failed (fatal).";
+ // TODO(piman): can we signal overall failure?
+ break;
+ case gpu::kCollectInfoNonFatalFailure:
+ DVLOG(1) << "gpu::CollectGraphicsInfo failed (non-fatal).";
+ break;
+ case gpu::kCollectInfoNone:
+ NOTREACHED();
+ break;
+ case gpu::kCollectInfoSuccess:
+ break;
+ }
+ gpu::SetKeysForCrashLogging(gpu_info_);
}
- gpu::SetKeysForCrashLogging(gpu_info_);
}
#elif defined(OS_WIN)
void GpuService::UpdateGpuInfoPlatform() {
« gpu/config/gpu_driver_bug_list.json ('K') | « gpu/ipc/service/gpu_init.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698