Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2934703002: PaymentHandler: Replace sequence with FrozenArray in PaymentRequestEvent.idl. (Closed)

Created:
3 years, 6 months ago by zino
Modified:
3 years, 6 months ago
CC:
chromium-reviews, blink-reviews, gogerald+paymentswatch_chromium.org, haraken, rouslan+payments_chromium.org, mahmadi+paymentswatch_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace sequence with FrozenArray in PaymentRequestEvent.idl. According to the spec[1], |methodData| and |modifiers| attributes should be FrozenArray instead of sequence. [1] https://w3c.github.io/payment-handler/#the-paymentrequestevent BUG=661608, 720027 Review-Url: https://codereview.chromium.org/2934703002 Cr-Commit-Position: refs/heads/master@{#478647} Committed: https://chromium.googlesource.com/chromium/src/+/87f775b01eff2468818a0ef5476ee1f6177bc9b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
zino
PTAL
3 years, 6 months ago (2017-06-11 15:01:45 UTC) #4
please use gerrit instead
lgtm
3 years, 6 months ago (2017-06-12 14:04:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2934703002/1
3 years, 6 months ago (2017-06-12 14:04:43 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 16:12:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/87f775b01eff2468818a0ef5476e...

Powered by Google App Engine
This is Rietveld 408576698