Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2934673002: Revert of Draggable peeking/fullscreen launcher with transparent background. (Closed)

Created:
3 years, 6 months ago by Devlin
Modified:
3 years, 6 months ago
Reviewers:
xiyuan, msw, vadimt, newcomer, sky
CC:
chromium-reviews, kalyank, sadrul, Matt Giuca, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Draggable peeking/fullscreen launcher with transparent background. (patchset #20 id:950001 of https://codereview.chromium.org/2898743002/ ) Reason for revert: Caused gn check failures: Running ['/usr/bin/python', '/b/c/b/linux/src/build/check_gn_headers.py', '--out-dir', u'/b/c/b/linux/src/out/Debug', '--whitelist', '/b/c/b/linux/src/build/check_gn_headers_whitelist.txt', '--json', '/tmp/tmpkLJpof'] in '/b/c/b/linux/src' (env: None) The following files should be included in gn files: ui/app_list/presenter/app_list_delegate.h ui/app_list/presenter/app_list_presenter_export.h e.g. https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/112082 Original issue's description: > Draggable peeking/fullscreen launcher with transparent background. > > UI tests are not yet implemented, waiting on final behavior from UX. > Enable the new launcher with --enable-features=EnableFullscreenAppList > > BUG=721781 > > Review-Url: https://codereview.chromium.org/2898743002 > Cr-Commit-Position: refs/heads/master@{#478372} > Committed: https://chromium.googlesource.com/chromium/src/+/01b3ff8dd7b21723108b7802164f3a8fa64dabce TBR=vadimt@chromium.org,sky@chromium.org,xiyuan@chromium.org,msw@chromium.org,newcomer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=721781 Review-Url: https://codereview.chromium.org/2934673002 Cr-Commit-Position: refs/heads/master@{#478437} Committed: https://chromium.googlesource.com/chromium/src/+/dc37aebdd0959866f81a5a4cda79cde2bf43ae4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -562 lines) Patch
M ash/app_list/app_list_delegate_impl.cc View 2 chunks +15 lines, -7 lines 0 comments Download
M ash/app_list/app_list_presenter_delegate.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M ash/app_list/app_list_presenter_delegate_unittest.cc View 8 chunks +5 lines, -71 lines 0 comments Download
M ash/public/cpp/shell_window_ids.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/root_window_controller.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ash/shelf/app_list_button.h View 3 chunks +1 line, -7 lines 0 comments Download
M ash/shelf/app_list_button.cc View 3 chunks +2 lines, -15 lines 0 comments Download
M ash/shelf/shelf_layout_manager.h View 3 chunks +1 line, -6 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M ash/shell.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/shell.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M ash/shell_observer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/app_list/app_list_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/app_list_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/presenter/app_list_presenter_impl.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M ui/app_list/views/all_apps_tile_item_view.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/app_list/views/all_apps_tile_item_view.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M ui/app_list/views/app_list_main_view.h View 3 chunks +1 line, -3 lines 0 comments Download
M ui/app_list/views/app_list_main_view.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ui/app_list/views/app_list_main_view_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ui/app_list/views/app_list_view.h View 7 chunks +6 lines, -61 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 12 chunks +21 lines, -238 lines 0 comments Download
M ui/app_list/views/contents_view.h View 3 chunks +1 line, -5 lines 0 comments Download
M ui/app_list/views/contents_view.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M ui/app_list/views/search_box_view.h View 3 chunks +1 line, -4 lines 0 comments Download
M ui/app_list/views/search_box_view.cc View 7 chunks +5 lines, -32 lines 0 comments Download
M ui/app_list/views/start_page_view.h View 3 chunks +2 lines, -4 lines 0 comments Download
M ui/app_list/views/start_page_view.cc View 9 chunks +12 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Devlin
Created Revert of Draggable peeking/fullscreen launcher with transparent background.
3 years, 6 months ago (2017-06-09 22:34:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2934673002/1
3 years, 6 months ago (2017-06-09 22:35:28 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 22:36:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dc37aebdd0959866f81a5a4cda79...

Powered by Google App Engine
This is Rietveld 408576698