Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2934573002: [Extensions Bindings] Update test to not use idle (Closed)

Created:
3 years, 6 months ago by Devlin
Modified:
3 years, 6 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Update test to not use idle The chrome.idle test is flaky (because the result is unknown). Move to a more stable API. BUG=653596 Review-Url: https://codereview.chromium.org/2934573002 Cr-Commit-Position: refs/heads/master@{#478410} Committed: https://chromium.googlesource.com/chromium/src/+/07b2843ad74247b776c43ad7a21945813f05ac33

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M chrome/test/data/extensions/api_test/native_bindings/extension/background.js View 1 chunk +10 lines, -13 lines 0 comments Download
M chrome/test/data/extensions/api_test/native_bindings/extension/manifest.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (13 generated)
Devlin
lazyboy@, mind taking a quick look? I'm seeing these failing on the tree, e.g.: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Tests__dbg__1__32_%2F41617%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FNativeBindingsApiTest.SimpleEndToEndTest%2F0 ...
3 years, 6 months ago (2017-06-09 20:34:54 UTC) #8
lazyboy
lgtm
3 years, 6 months ago (2017-06-09 20:49:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2934573002/20001
3 years, 6 months ago (2017-06-09 20:50:50 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 20:55:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/07b2843ad74247b776c43ad7a219...

Powered by Google App Engine
This is Rietveld 408576698