Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2934553002: PPC: Add the missing cmp instr for 32bit (Closed)

Created:
3 years, 6 months ago by JaideepBajwa
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Add the missing cmp instr for 32bit Minor fix to original CL https://chromium-review.googlesource.com/527156 adding the cmp instr to set the condition code for 32bit. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2934553002 Cr-Commit-Position: refs/heads/master@{#45828} Committed: https://chromium.googlesource.com/v8/v8/+/03ee37859c1fa49dc2f7bb0943e2c81779cc3619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 6 months ago (2017-06-09 17:50:40 UTC) #1
john.yan
lgtm
3 years, 6 months ago (2017-06-09 17:52:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2934553002/1
3 years, 6 months ago (2017-06-09 17:53:16 UTC) #4
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 18:14:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/03ee37859c1fa49dc2f7bb0943e2c81779c...

Powered by Google App Engine
This is Rietveld 408576698