Sending a page load pingback to data saver for holdback users

chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc

Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
index ac083d02c24a86acfa58bc113245dd2372898bc8..8bbcc3494c7516142b156bfc2a2b999117ec9d05 100644
--- a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
@@ -114,6 +114,7 @@ class TestDataReductionProxyMetricsObserver
     DataReductionProxyData* data =
         DataForNavigationHandle(web_contents_, navigation_handle);
     data->set_used_data_reduction_proxy(data_reduction_proxy_used_);
+    data->set_request_url(GURL(kDefaultTestUrl));
     data->set_lofi_requested(lofi_used_);
     return DataReductionProxyMetricsObserver::OnCommit(navigation_handle,
                                                        source_id);
@@ -417,6 +418,7 @@ TEST_F(DataReductionProxyMetricsObserverTest, OnCompletePingback) {
   std::unique_ptr<DataReductionProxyData> data =
       base::MakeUnique<DataReductionProxyData>();
   data->set_used_data_reduction_proxy(true);
+  data->set_request_url(GURL(kDefaultTestUrl));
   data->set_lofi_received(true);
 
   // Verify LoFi is tracked when a LoFi response is received.
@@ -443,12 +445,12 @@ TEST_F(DataReductionProxyMetricsObserverTest, OnCompletePingback) {
   EXPECT_FALSE(pingback_client_->send_pingback_called());
 
   ResetTest();
-  // Verify that when the holdback experiment is enabled, no pingback is sent.
+  // Verify that when the holdback experiment is enabled, a pingback is sent.
   base::FieldTrialList field_trial_list(nullptr);
   ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
       "DataCompressionProxyHoldback", "Enabled"));
   RunTestAndNavigateToUntrackedUrl(true, false);
-  EXPECT_FALSE(pingback_client_->send_pingback_called());
+  EXPECT_TRUE(pingback_client_->send_pingback_called());
 }
 
 TEST_F(DataReductionProxyMetricsObserverTest, ByteInformationCompression) {
@@ -459,6 +461,7 @@ TEST_F(DataReductionProxyMetricsObserverTest, ByteInformationCompression) {
   std::unique_ptr<DataReductionProxyData> data =
       base::MakeUnique<DataReductionProxyData>();
   data->set_used_data_reduction_proxy(true);
+  data->set_request_url(GURL(kDefaultTestUrl));
 
   // Prepare 4 resources of varying size and configurations.
   page_load_metrics::ExtraRequestCompleteInfo resources[] = {
@@ -518,6 +521,7 @@ TEST_F(DataReductionProxyMetricsObserverTest, ByteInformationInflation) {
   std::unique_ptr<DataReductionProxyData> data =
       base::MakeUnique<DataReductionProxyData>();
   data->set_used_data_reduction_proxy(true);
+  data->set_request_url(GURL(kDefaultTestUrl));
 
   // Prepare 4 resources of varying size and configurations.
   page_load_metrics::ExtraRequestCompleteInfo resources[] = {