Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1982)

Unified Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc

Issue 2934543002: Sending a page load pingback to data saver for holdback users (Closed)
Patch Set: tbansl comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
index 5e05b1b122ff8f69e914298526bf21326d8853f9..6f5b75b4236ed663dd17106d0c8ed913127b2a00 100644
--- a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
@@ -152,6 +152,7 @@ DataReductionProxyMetricsObserver::OnCommit(
data_ = data->DeepCopy();
// DataReductionProxy page loads should only occur on HTTP navigations.
DCHECK(!navigation_handle->GetURL().SchemeIsCryptographic());
+ DCHECK_EQ(data_->request_url(), navigation_handle->GetURL());
return CONTINUE_OBSERVING;
}
@@ -278,10 +279,6 @@ void DataReductionProxyMetricsObserver::SendPingback(
// shutdown cases. crbug.com/618072
if (!browser_context_ || !data_)
return;
- if (data_reduction_proxy::params::IsIncludedInHoldbackFieldTrial() ||
- data_reduction_proxy::params::IsIncludedInTamperDetectionExperiment()) {
- return;
- }
// Only consider timing events that happened before the first background
// event.
base::Optional<base::TimeDelta> response_start;
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698