components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc - Issue 2934543002: Sending a page load pingback to data saver for holdback users

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc

Issue 2934543002: Sending a page load pingback to data saver for holdback users (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc ('K') | « chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client_unittest.cc » ('j') | components/data_reduction_proxy/proto/pageload_metrics.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc

index 24aa6a384bc318cb5821d5574d3df6e3259da4ed..b3d2228803ac38783bbb537290028aded9cd2821 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc

@@ -42,6 +42,7 @@ void AddDataToPageloadMetrics(const DataReductionProxyData& request_data,

PageloadMetrics* request,

bool opted_out) {

request->set_session_key(request_data.session_key());

+ request->set_holdback_experiment(params::IsIncludedInHoldbackFieldTrial());

// For the timing events, any of them could be zero. Fill the message as a

// best effort.

request->set_allocated_first_request_time(