Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2934513002: Setting for toggling new FeedbackKit (Closed)

Created:
3 years, 6 months ago by PL
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Setting for toggling new FeedbackKit. BUG=657076 TEST=Setting appears in Settings experiments list in UI section. Review-Url: https://codereview.chromium.org/2934513002 Cr-Commit-Position: refs/heads/master@{#478412} Committed: https://chromium.googlesource.com/chromium/src/+/ad6b46068f1239aa816fc542d2821c91c6fea436

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M ios/chrome/browser/experimental_flags.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M ios/chrome/browser/resources/Settings.bundle/Experimental.plist View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
PL
Hi Rohit, This is a simple setting to allow for the toggling of the adoption ...
3 years, 6 months ago (2017-06-09 16:07:44 UTC) #4
pkl (ping after 24h if needed)
lgtm
3 years, 6 months ago (2017-06-09 17:05:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2934513002/1
3 years, 6 months ago (2017-06-09 17:10:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/460266)
3 years, 6 months ago (2017-06-09 17:19:15 UTC) #12
rohitrao (ping after 24h)
lgtm
3 years, 6 months ago (2017-06-09 17:42:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2934513002/1
3 years, 6 months ago (2017-06-09 20:57:26 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 21:04:10 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ad6b46068f1239aa816fc542d282...

Powered by Google App Engine
This is Rietveld 408576698