Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2934503002: Remove references to ui/views/layout/layout_constants.h (Closed)

Created:
3 years, 6 months ago by ananta
Modified:
3 years, 6 months ago
Reviewers:
Peter Kasting, sky
CC:
chromium-reviews, juncai+watch_chromium.org, extensions-reviews_chromium.org, rouslan+autofill_chromium.org, tfarina, sebsg+autofillwatch_chromium.org, chromium-apps-reviews_chromium.org, mathp+autofillwatch_chromium.org, oshima+watch_chromium.org, rogerm+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove references to ui/views/layout/layout_constants.h Replace references to constants in ui/views/layout/layout_constants.h with their equivalents using ChromeLayoutProvider. The approach taken is to push the DISTANCE_UNRELATED_CONTROL_VERTICAL constant down to views::LayoutProvider. Other approaches considered were to use DISTANCE_RELATED_CONTROL_VERTICAL here which did not seem correct or define a local constant in the dialog_example.cc BUG=691897 Review-Url: https://codereview.chromium.org/2934503002 Cr-Commit-Position: refs/heads/master@{#478427} Committed: https://chromium.googlesource.com/chromium/src/+/478f3b20593b53ce53fb65e9b70fb3d59f15d17d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -42 lines) Patch
M chrome/browser/chromeos/enrollment_dialog_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/save_card_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/crypto_module_password_dialog_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/chooser_dialog_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/harmony/chrome_layout_provider.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/harmony/chrome_layout_provider.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/harmony/harmony_layout_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/login_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/sad_tab_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/try_chrome_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/uninstall_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/examples/dialog_example.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M ui/views/layout/layout_provider.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/layout/layout_provider.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
ananta
3 years, 6 months ago (2017-06-09 18:44:31 UTC) #6
Peter Kasting
LGTM
3 years, 6 months ago (2017-06-09 19:52:20 UTC) #7
ananta
+sky for ui\views owners
3 years, 6 months ago (2017-06-09 21:22:42 UTC) #10
sky
LGTM
3 years, 6 months ago (2017-06-09 21:22:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2934503002/1
3 years, 6 months ago (2017-06-09 21:35:12 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 21:40:23 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/478f3b20593b53ce53fb65e9b70f...

Powered by Google App Engine
This is Rietveld 408576698