Remove workaround for strikethrough text in iOS omnibox

Remove workaround for strikethrough text in iOS omnibox

iOS 10.3 introduced a regression in rendering of strings with the
attribute NSStrikethroughStyleAttributeName applied to a subrange of
the string. For crbug.com/699702, we introduced a workaround that is
no longer needed as of iOS 10.3.2. We will remove that workaround now
that iOS 10.3.2 has released.

BUG=711367
TEST=https://expired.badssl.com. Examine https: text in the omnibox,
it should have a line through it.

Review-Url: https://codereview.chromium.org/2934473003
Cr-Commit-Position: refs/heads/master@{#479799}
Committed: https://chromium.googlesource.com/chromium/src/+/927047b0999e1fa6c164d581bdd5ec3b0e4d1f64

[elawrence, 2017-06-09 16:45:16]

The CQ bit was checked by elawrence@chromium.org to run a CQ dry run

[elawrence, 2017-06-09 16:45:19]

elawrence@chromium.org changed reviewers:
+ rohitrao@chromium.org

[elawrence, 2017-06-09 16:45:20]

PTAL?

[commit-bot: I haz the power, 2017-06-09 16:45:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 17:01:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 17:01:32]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-06-09 17:47:35]

Do you want to hold this CL and only submit after our iOS 10.3 and 10.3.1 usage
falls below X% of users?  What value of X would you choose?

[elawrence, 2017-06-09 19:58:20]

On 2017/06/09 17:47:35, rohitrao (ping after 24h) wrote:
> Do you want to hold this CL and only submit after our iOS 10.3 and 10.3.1
usage
> falls below X% of users?  What value of X would you choose?

Is there a straightforward way for us to watch iOS update rates in UMA? I
couldn't find one. :-/

As to the question of whether to hold this, I'd defer to someone more familiar
with iOS to understand our general practices there. We made the original
low-priority fix because we believed it possible that Apple might never fix
their regression, but now that they have, I don't think it's a real problem if
some users who haven't updated get a slightly inferior error UI.

[rohitrao (ping after 24h), 2017-06-15 18:18:57]

lgtm

We synced up offline and decided that removing this workaround now is fine, even
if not all users have updated to 10.3.2.

[elawrence, 2017-06-15 18:25:10]

The CQ bit was checked by elawrence@chromium.org

[elawrence, 2017-06-15 18:25:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2934473003/#ps20001
(title: "rebse")

[commit-bot: I haz the power, 2017-06-15 18:25:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 18:49:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 18:49:30]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[elawrence, 2017-06-15 18:56:24]

The CQ bit was checked by elawrence@chromium.org

[commit-bot: I haz the power, 2017-06-15 18:56:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 19:18:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 19:18:52]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[elawrence, 2017-06-15 19:42:33]

The CQ bit was checked by elawrence@chromium.org

[commit-bot: I haz the power, 2017-06-15 19:43:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 19:59:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497555753977980,
"parent_rev": "a8599ca28499cb5770adc9219857b3a0dff4b90b", "commit_rev":
"927047b0999e1fa6c164d581bdd5ec3b0e4d1f64"}

[commit-bot: I haz the power, 2017-06-15 19:59:44]

Description was changed from

==========
Remove workaround for strikethrough text in iOS omnibox

iOS 10.3 introduced a regression in rendering of strings with the
attribute NSStrikethroughStyleAttributeName applied to a subrange of
the string. For crbug.com/699702, we introduced a workaround that is
no longer needed as of iOS 10.3.2. We will remove that workaround now
that iOS 10.3.2 has released.

BUG=711367

TEST=https://expired.badssl.com. Examine https: text in the omnibox,
it should have a line through it.
==========

to

==========
Remove workaround for strikethrough text in iOS omnibox

iOS 10.3 introduced a regression in rendering of strings with the
attribute NSStrikethroughStyleAttributeName applied to a subrange of
the string. For crbug.com/699702, we introduced a workaround that is
no longer needed as of iOS 10.3.2. We will remove that workaround now
that iOS 10.3.2 has released.

BUG=711367

TEST=https://expired.badssl.com. Examine https: text in the omnibox,
it should have a line through it.

Review-Url: https://codereview.chromium.org/2934473003
Cr-Commit-Position: refs/heads/master@{#479799}
Committed:
https://chromium.googlesource.com/chromium/src/+/927047b0999e1fa6c164d581bdd5...
==========

[commit-bot: I haz the power, 2017-06-15 19:59:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/927047b0999e1fa6c164d581bdd5...