[iOS] Add experimental new keyboard accessory view.

[iOS] Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

Note that the assets used in this CL are temporary.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera
search (aka QR code scanner).
-a KeyboardAccessoryViewProtocol is introduced.
-a new implementation of that protocol is added. Main difference is that
there is only one mode which contains all the buttons, cf mock
mentioned at the beginning of the CL description.

BUG=642702
Review-Url: https://codereview.chromium.org/2934463002
Cr-Commit-Position: refs/heads/master@{#479090}
Committed: https://chromium.googlesource.com/chromium/src/+/225a43bd9a7550f1578d5d279707c78785f4ce1d

[jif, 2017-06-09 09:44:57]

Description was changed from

==========
Add new keyboard accessory view design.

BUG=None
==========

to

==========
Add new keyboard accessory view design.

BUG=None
==========

[jif, 2017-06-09 09:44:57]

jif@chromium.org changed reviewers:
+ gambard@chromium.org

[jif, 2017-06-09 09:45:04]

ptal

[jif, 2017-06-09 09:45:20]

Description was changed from

==========
Add new keyboard accessory view design.

BUG=None
==========

to

==========
Add experimental new keyboard accessory view.

BUG=None
==========

[jif, 2017-06-09 09:46:58]

Description was changed from

==========
Add experimental new keyboard accessory view.

BUG=None
==========

to

==========
Add experimental new keyboard accessory view.

This new keyboard accessory view is enabled with an experimental flag.
As part of this CL, tinted_button is extended to support specifying state
specific background colors.

BUG=642702
==========

[jif, 2017-06-09 09:49:21]

Description was changed from

==========
Add experimental new keyboard accessory view.

This new keyboard accessory view is enabled with an experimental flag.
As part of this CL, tinted_button is extended to support specifying state
specific background colors.

BUG=642702
==========

to

==========
Add experimental new keyboard accessory view.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera search (aka QR
code scanner).

BUG=642702
==========

[jif, 2017-06-09 12:34:34]

Description was changed from

==========
Add experimental new keyboard accessory view.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera search (aka QR
code scanner).

BUG=642702
==========

to

==========
Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera search (aka QR
code scanner).
-the keyboard accessory view only has one single mode: no toggling between Voice
Search and the Keyboard Shortcuts modes.

BUG=642702
==========

[jif, 2017-06-09 12:34:48]

Description was changed from

==========
Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera search (aka QR
code scanner).
-the keyboard accessory view only has one single mode: no toggling between Voice
Search and the Keyboard Shortcuts modes.

BUG=642702
==========

to

==========
Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera
search (aka QR code scanner).
-the keyboard accessory view only has one single mode: no toggling
between Voice Search and the Keyboard Shortcuts modes.

BUG=642702
==========

[gambard, 2017-06-09 12:35:42]

https://codereview.chromium.org/2934463002/diff/20001/ios/chrome/browser/expe...
File ios/chrome/browser/experimental_flags.h (right):

https://codereview.chromium.org/2934463002/diff/20001/ios/chrome/browser/expe...
ios/chrome/browser/experimental_flags.h:107: bool
IsNewKeyboardAccessoryViewEnabled();
Maybe something more specific? IsKeyboardImageSearchEnabled?

https://codereview.chromium.org/2934463002/diff/20001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/toolbar/keyboard_accessory_view.mm (right):

https://codereview.chromium.org/2934463002/diff/20001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/keyboard_accessory_view.mm:57: if
(experimental_flags::IsNewKeyboardAccessoryViewEnabled()) {
This is a >160 lines methods. Maybe we can split it into
"newAccessoryInitialization" and "accessoryInitialization" to make it more
readable?

https://codereview.chromium.org/2934463002/diff/20001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/keyboard_accessory_view.mm:255: -
(UIView*)newShortcutButtonWithTitle:(NSString*)title {
Don't start method with new to avoid memory issue.

https://codereview.chromium.org/2934463002/diff/20001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm (right):

https://codereview.chromium.org/2934463002/diff/20001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm:1856: [NSArray
arrayWithObjects:@":", @"-", @"/", kDotComTLD, nil];
Why removing the dot?

[jif, 2017-06-09 12:35:49]

Description was changed from

==========
Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera
search (aka QR code scanner).
-the keyboard accessory view only has one single mode: no toggling
between Voice Search and the Keyboard Shortcuts modes.

BUG=642702
==========

to

==========
Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

Note that the assets used are temporary.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera
search (aka QR code scanner).
-the keyboard accessory view only has one single mode: no toggling
between Voice Search and the Keyboard Shortcuts modes.

BUG=642702
==========

[jif, 2017-06-09 13:19:38]

thanks.
ptal.

https://codereview.chromium.org/2934463002/diff/20001/ios/chrome/browser/expe...
File ios/chrome/browser/experimental_flags.h (right):

https://codereview.chromium.org/2934463002/diff/20001/ios/chrome/browser/expe...
ios/chrome/browser/experimental_flags.h:107: bool
IsNewKeyboardAccessoryViewEnabled();
On 2017/06/09 12:35:42, gambard wrote:
> Maybe something more specific? IsKeyboardImageSearchEnabled?

Done.

https://codereview.chromium.org/2934463002/diff/20001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/toolbar/keyboard_accessory_view.mm (right):

https://codereview.chromium.org/2934463002/diff/20001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/keyboard_accessory_view.mm:57: if
(experimental_flags::IsNewKeyboardAccessoryViewEnabled()) {
On 2017/06/09 12:35:42, gambard wrote:
> This is a >160 lines methods. Maybe we can split it into
> "newAccessoryInitialization" and "accessoryInitialization" to make it more
> readable?

Done.

https://codereview.chromium.org/2934463002/diff/20001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/keyboard_accessory_view.mm:255: -
(UIView*)newShortcutButtonWithTitle:(NSString*)title {
On 2017/06/09 12:35:42, gambard wrote:
> Don't start method with new to avoid memory issue.

Good catch :-)
Done and done.

https://codereview.chromium.org/2934463002/diff/20001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm (right):

https://codereview.chromium.org/2934463002/diff/20001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm:1856: [NSArray
arrayWithObjects:@":", @"-", @"/", kDotComTLD, nil];
On 2017/06/09 12:35:42, gambard wrote:
> Why removing the dot?

Added comment.

[gambard, 2017-06-09 13:30:51]

lgtm with comments

https://codereview.chromium.org/2934463002/diff/40001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/toolbar/keyboard_accessory_view.mm (right):

https://codereview.chromium.org/2934463002/diff/40001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/keyboard_accessory_view.mm:66: -
(void)newAccessoryInitialization:(NSArray<NSString*>*)buttonTitles {
I know I suggested the name and it is returning void, but I would avoid the
"new" keyword at the beginning of the method.

https://codereview.chromium.org/2934463002/diff/40001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/keyboard_accessory_view.mm:66: -
(void)newAccessoryInitialization:(NSArray<NSString*>*)buttonTitles {
Comment for the method

https://codereview.chromium.org/2934463002/diff/40001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/keyboard_accessory_view.mm:146: -
(void)accessoryInitialization:(NSArray<NSString*>*)buttonTitles {
Comment for the method.

[jif, 2017-06-09 14:13:01]

jif@chromium.org changed reviewers:
+ marq@chromium.org

[jif, 2017-06-09 14:13:39]

thanks.

+marq for OWNERS check

[jif, 2017-06-09 14:14:19]

Description was changed from

==========
Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

Note that the assets used are temporary.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera
search (aka QR code scanner).
-the keyboard accessory view only has one single mode: no toggling
between Voice Search and the Keyboard Shortcuts modes.

BUG=642702
==========

to

==========
Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

Note that the assets used in this CL are temporary.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera
search (aka QR code scanner).
-the keyboard accessory view only has one single mode: no toggling
between Voice Search and the Keyboard Shortcuts modes.

BUG=642702
==========

[jif, 2017-06-09 14:14:37]

Description was changed from

==========
Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

Note that the assets used in this CL are temporary.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera
search (aka QR code scanner).
-the keyboard accessory view only has one single mode: no toggling
between Voice Search and the Keyboard Shortcuts modes.

BUG=642702
==========

to

==========
[iOS] Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

Note that the assets used in this CL are temporary.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera
search (aka QR code scanner).
-the keyboard accessory view only has one single mode: no toggling
between Voice Search and the Keyboard Shortcuts modes.

BUG=642702
==========

[jif, 2017-06-09 15:06:33]

Description was changed from

==========
[iOS] Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

Note that the assets used in this CL are temporary.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera
search (aka QR code scanner).
-the keyboard accessory view only has one single mode: no toggling
between Voice Search and the Keyboard Shortcuts modes.

BUG=642702
==========

to

==========
[iOS] Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

Note that the assets used in this CL are temporary.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera
search (aka QR code scanner).
-a KeyboardAccessoryViewProtocol is introduced.
-a new implementation of that protocol is added. Main difference is that there
is no difference between the Voice Search and the Keyboard Shortcuts modes.

BUG=642702
==========

[jif, 2017-06-09 15:06:46]

Description was changed from

==========
[iOS] Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

Note that the assets used in this CL are temporary.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera
search (aka QR code scanner).
-a KeyboardAccessoryViewProtocol is introduced.
-a new implementation of that protocol is added. Main difference is that there
is no difference between the Voice Search and the Keyboard Shortcuts modes.

BUG=642702
==========

to

==========
[iOS] Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

Note that the assets used in this CL are temporary.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera
search (aka QR code scanner).
-a KeyboardAccessoryViewProtocol is introduced.
-a new implementation of that protocol is added. Main difference is that
there is no difference between the Voice Search and the Keyboard
Shortcuts modes.

BUG=642702
==========

[jif, 2017-06-09 15:10:18]

Patchset #4 (id:60001) has been deleted

[jif, 2017-06-09 15:14:02]

Description was changed from

==========
[iOS] Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

Note that the assets used in this CL are temporary.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera
search (aka QR code scanner).
-a KeyboardAccessoryViewProtocol is introduced.
-a new implementation of that protocol is added. Main difference is that
there is no difference between the Voice Search and the Keyboard
Shortcuts modes.

BUG=642702
==========

to

==========
[iOS] Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

Note that the assets used in this CL are temporary.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera
search (aka QR code scanner).
-a KeyboardAccessoryViewProtocol is introduced.
-a new implementation of that protocol is added. Main difference is that
there is only one mode which contains all the buttons, cf mock
mentioned at the beginning of the CL description.

BUG=642702
==========

[jif, 2017-06-09 15:15:25]

marq ptal (for real this time).

https://codereview.chromium.org/2934463002/diff/40001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/toolbar/keyboard_accessory_view.mm (right):

https://codereview.chromium.org/2934463002/diff/40001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/keyboard_accessory_view.mm:66: -
(void)newAccessoryInitialization:(NSArray<NSString*>*)buttonTitles {
On 2017/06/09 13:30:51, gambard wrote:
> I know I suggested the name and it is returning void, but I would avoid the
> "new" keyword at the beginning of the method.

facepalm. Done.

https://codereview.chromium.org/2934463002/diff/40001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/keyboard_accessory_view.mm:66: -
(void)newAccessoryInitialization:(NSArray<NSString*>*)buttonTitles {
On 2017/06/09 13:30:51, gambard wrote:
> Comment for the method

Done.

[jif, 2017-06-09 15:16:14]

Patchset #1 (id:1) has been deleted

[marq (ping after 24h), 2017-06-12 17:34:36]

Overall fine, just a couple of questions/nits.

https://codereview.chromium.org/2934463002/diff/80001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm (right):

https://codereview.chromium.org/2934463002/diff/80001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm:28: 
Either delete this newline, or add one after line 30.

https://codereview.chromium.org/2934463002/diff/80001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm:165: font =
GetUIFont(FONT_HELVETICA, false, kIpadButtonTitleFontSize);
is this actually Helvetica, or is it San Francisco (or Roboto?)

https://codereview.chromium.org/2934463002/diff/80001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm (right):

https://codereview.chromium.org/2934463002/diff/80001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm:1860: [NSArray
arrayWithObjects:@":", @"-", @"/", kDotComTLD, nil];
Just use @[ ... ] instead of the nil-terminated -arrayWithObjects.

(here and below)

[jif, 2017-06-12 18:26:01]

Thanks.
PTAL.

https://codereview.chromium.org/2934463002/diff/80001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm (right):

https://codereview.chromium.org/2934463002/diff/80001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm:165: font =
GetUIFont(FONT_HELVETICA, false, kIpadButtonTitleFontSize);
On 2017/06/12 17:34:36, marq (ping after 24h) wrote:
> is this actually Helvetica, or is it San Francisco (or Roboto?)

Switching to San Francisco to match the iOS keyboard. We should probably do this
for the existing keyboard accessory view. Filed crbug.com/732472 to ask
pschaffner for confirmation

https://codereview.chromium.org/2934463002/diff/80001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm (right):

https://codereview.chromium.org/2934463002/diff/80001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm:1860: [NSArray
arrayWithObjects:@":", @"-", @"/", kDotComTLD, nil];
On 2017/06/12 17:34:36, marq (ping after 24h) wrote:
> Just use @[ ... ] instead of the nil-terminated -arrayWithObjects.
> 
> (here and below)

Done.

[jif, 2017-06-13 07:40:22]

The CQ bit was checked by jif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 07:40:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 07:42:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 07:42:42]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[marq (ping after 24h), 2017-06-13 14:06:36]

lgtm

[jif, 2017-06-13 16:05:57]

The CQ bit was checked by jif@chromium.org

[jif, 2017-06-13 16:05:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
gambard@chromium.org, marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2934463002/#ps120001
(title: "Rebased.")

[commit-bot: I haz the power, 2017-06-13 16:06:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 17:04:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 17:04:05]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jif, 2017-06-13 17:13:18]

The CQ bit was checked by jif@chromium.org

[commit-bot: I haz the power, 2017-06-13 17:13:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 19:06:11]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1497373998120970,
"parent_rev": "49a24dab4bd0966d7efeb27d307f598bebca9da7", "commit_rev":
"225a43bd9a7550f1578d5d279707c78785f4ce1d"}

[commit-bot: I haz the power, 2017-06-13 19:06:25]

Description was changed from

==========
[iOS] Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

Note that the assets used in this CL are temporary.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera
search (aka QR code scanner).
-a KeyboardAccessoryViewProtocol is introduced.
-a new implementation of that protocol is added. Main difference is that
there is only one mode which contains all the buttons, cf mock
mentioned at the beginning of the CL description.

BUG=642702
==========

to

==========
[iOS] Add experimental new keyboard accessory view.

See https://bugs.chromium.org/p/chromium/issues/detail?id=642702#c28
for an idea of what it should look like.

Note that the assets used in this CL are temporary.

As part of this CL:
-An experimental flag is added to enable the new keyboard accessory view.
-tinted_button is extended to support specifying state specific background
colors.
-the KeyboardAccessoryViewDelegate now support opening the camera
search (aka QR code scanner).
-a KeyboardAccessoryViewProtocol is introduced.
-a new implementation of that protocol is added. Main difference is that
there is only one mode which contains all the buttons, cf mock
mentioned at the beginning of the CL description.

BUG=642702

Review-Url: https://codereview.chromium.org/2934463002
Cr-Commit-Position: refs/heads/master@{#479090}
Committed:
https://chromium.googlesource.com/chromium/src/+/225a43bd9a7550f1578d5d279707...
==========

[commit-bot: I haz the power, 2017-06-13 19:06:27]

Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/225a43bd9a7550f1578d5d279707...