Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2934453004: [Autofill] Fixes bug where toggling Google Payments switch was crashing cr. (Closed)

Created:
3 years, 6 months ago by Moe
Modified:
3 years, 6 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Fix bug where toggling Google Payments switch was crashing cr. Toggling the Google Payments switch toggles the autofill::prefs::kAutofillWalletImportEnabled which is watched by the autofill::PersonalDataManager. If as a result of this, there is any change to the list of autofill profiles and credit cards, PersonalDataManager notifies its observers via -onPersonalDataChanged where AutofillCollectionViewController reloads the model. Therefore no item or section needs to be added/removed when the swtich is toggled. BUG=671552 Review-Url: https://codereview.chromium.org/2934453004 Cr-Commit-Position: refs/heads/master@{#478566} Committed: https://chromium.googlesource.com/chromium/src/+/0d54f827187467f83c0983b6745f93fe78949e18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm View 2 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Moe
Hi Louis, Please take a look.
3 years, 6 months ago (2017-06-09 18:19:21 UTC) #4
lpromero
lgtm
3 years, 6 months ago (2017-06-12 08:28:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2934453004/1
3 years, 6 months ago (2017-06-12 08:28:43 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 08:40:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0d54f827187467f83c0983b6745f...

Powered by Google App Engine
This is Rietveld 408576698