Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2934453003: Add string for cache and cookies to important sites (Closed)

Created:
3 years, 6 months ago by dullweber
Modified:
3 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add string for cache and cookies to important sites The important sites dialog on desktop is only triggered when cookies are selected for deletion but cache is also protected, so the string needs to be different in case cookies and cache are supposed to be deleted. BUG=698692 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2934453003 Cr-Commit-Position: refs/heads/master@{#478579} Committed: https://chromium.googlesource.com/chromium/src/+/2f151da52049d5db6abd58ddc30551bee99f6ec4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
dullweber
dbeam@chromium.org: Please review these changes
3 years, 6 months ago (2017-06-09 10:59:18 UTC) #5
Dan Beam
lgtm
3 years, 6 months ago (2017-06-09 18:53:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2934453003/1
3 years, 6 months ago (2017-06-12 08:00:38 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 10:16:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2f151da52049d5db6abd58ddc305...

Powered by Google App Engine
This is Rietveld 408576698