Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2934413002: [ObjC ARC] Converts ios/web:ios_web_inttests to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
stkhapugin
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/web:ios_web_inttests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2934413002 Cr-Commit-Position: refs/heads/master@{#479719} Committed: https://chromium.googlesource.com/chromium/src/+/687e15bb3699072e965c4c8b02c93aec933521b8

Patch Set 1 #

Patch Set 2 : rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ios/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/browser_state_web_view_partition_inttest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/navigation_callbacks_inttest.mm View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
marq (ping after 24h)
rebased.
3 years, 6 months ago (2017-06-15 11:47:54 UTC) #5
marq (ping after 24h)
Re-land of this -- it passed upstream bots.
3 years, 6 months ago (2017-06-15 13:09:34 UTC) #9
stkhapugin
lgtm
3 years, 6 months ago (2017-06-15 15:44:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2934413002/20001
3 years, 6 months ago (2017-06-15 15:47:57 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 15:53:20 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/687e15bb3699072e965c4c8b02c9...

Powered by Google App Engine
This is Rietveld 408576698