chrome/test/data/safe_browsing/mach_o/README - Issue 2934373002: Record Code Signature of Downloaded DMG files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/safe_browsing/mach_o/README

Issue 2934373002: Record Code Signature of Downloaded DMG files (Closed)

Patch Set: correcting rebase mixup Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/data/safe_browsing/mach_o/README

diff --git a/chrome/test/data/safe_browsing/mach_o/README b/chrome/test/data/safe_browsing/mach_o/README

index 60b51d11e4102eab3045e9d384122e07f3469f1d..848fb2b42c7ad5e23d2644c10db6278a0feedcee 100644

--- a/chrome/test/data/safe_browsing/mach_o/README

+++ b/chrome/test/data/safe_browsing/mach_o/README

@@ -12,3 +12,8 @@ only ever treated as data.

The `executableppc' file has no Makefile target, as modern Macs cannot build

for PPC. This file was created in a 10.6 VM with Xcode 3.2.6.

+Creating the signed binaries requires importing a temporary codesigning

+identity into the current user's keychain. This is because the `codesign -k`

+flag, which specifies a specific keychain file to use, is no longer respected.

+The temporary identity will be removed after the test binary is signed.