chrome/test/data/safe_browsing/mach_o/README - Issue 2934373002: Record Code Signature of Downloaded DMG files

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/safe_browsing/mach_o/README

Issue 2934373002: Record Code Signature of Downloaded DMG files (Closed)

Patch Set: correcting rebase mixup Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/test/data/safe_browsing/mach_o/Makefile ('k') | chrome/test/data/safe_browsing/mach_o/codesign.keychain » ('j') | no next file with comments »

OLD	NEW
1 This directory contains test data for //chrome/common/safe_browsing unit tests	1 This directory contains test data for //chrome/common/safe_browsing unit tests

2 on Mac OS X. The compiled binaries are checked in because the tests check	2 on Mac OS X. The compiled binaries are checked in because the tests check

3 specific values in the load commands, which will change on being recompiled.	3 specific values in the load commands, which will change on being recompiled.

4	4

5 In the event that the tests need to evolve, a Makefile is provided to recreate	5 In the event that the tests need to evolve, a Makefile is provided to recreate

6 the binaries. Note that recompiling or re-code-signing the binaries will	6 the binaries. Note that recompiling or re-code-signing the binaries will

7 require updating the test's assertions.	7 require updating the test's assertions.

8	8

9 Note that the executable bit has been removed from all of executable files,	9 Note that the executable bit has been removed from all of executable files,

10 since they do not have a common extension (for checkperms.py) and they are	10 since they do not have a common extension (for checkperms.py) and they are

11 only ever treated as data.	11 only ever treated as data.

12	12

13 The `executableppc' file has no Makefile target, as modern Macs cannot build	13 The `executableppc' file has no Makefile target, as modern Macs cannot build

14 for PPC. This file was created in a 10.6 VM with Xcode 3.2.6.	14 for PPC. This file was created in a 10.6 VM with Xcode 3.2.6.

	15

	16 Creating the signed binaries requires importing a temporary codesigning

	17 identity into the current user's keychain. This is because the `codesign -k`

	18 flag, which specifies a specific keychain file to use, is no longer respected.

	19 The temporary identity will be removed after the test binary is signed.

OLD	NEW