Avoid use-after-free when InterstitialPageImpl is being torn down.

Avoid use-after-free when InterstitialPageImpl is being torn down.

The InterstitialPageNavigatorImpl was continuing to access parts
of a deleted WebContents (e.g., the NavigationController) after its
corresponding InterstitialPageImpl was disabled.  This CL avoids
the problem by checking for the disabled state.

BUG=730592
TEST=NavigationHandleImpl crashes go away.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2934353002
Cr-Commit-Position: refs/heads/master@{#479544}
Committed: https://chromium.googlesource.com/chromium/src/+/f1ead56e93a1db602c7cdcf2a569bf8e0f4a8e52

[Charlie Reis, 2017-06-14 21:43:09]

Description was changed from

==========
Avoid use-after-free when InterstitialPageImpl is being torn down.

The InterstitialPageNavigatorImpl was continuing to access parts
of a deleted WebContents (e.g., the NavigationController) after its
corresponding InterstitialPageImpl was disabled.  This CL avoids
the problem by checking for the disabled state.

BUG=730592
TEST=NavigationHandleImpl crashes go away.
==========

to

==========
Avoid use-after-free when InterstitialPageImpl is being torn down.

The InterstitialPageNavigatorImpl was continuing to access parts
of a deleted WebContents (e.g., the NavigationController) after its
corresponding InterstitialPageImpl was disabled.  This CL avoids
the problem by checking for the disabled state.

BUG=730592
TEST=NavigationHandleImpl crashes go away.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Charlie Reis, 2017-06-14 21:46:24]

The CQ bit was checked by creis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 21:46:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2017-06-14 22:19:37]

The CQ bit was checked by creis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 22:19:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2017-06-14 22:22:03]

creis@chromium.org changed reviewers:
+ nick@chromium.org

[Charlie Reis, 2017-06-14 22:22:04]

Nick, can you take a look?  I'd love to make interstitial deletion synchronous
instead, but my straw man CL for that is failing tests, and it probably wouldn't
be safe to merge.  This continues the approach used in InterstitialPageImpl
itself.

[ncarter (slow), 2017-06-14 22:26:11]

lgtm

[Charlie Reis, 2017-06-14 22:46:04]

The CQ bit was unchecked by creis@chromium.org

[Charlie Reis, 2017-06-14 22:46:06]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2017-06-14 22:46:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 23:41:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497480366774920,
"parent_rev": "adfa94c6b41f0e13a1751a57279d8c5ac863718c", "commit_rev":
"f1ead56e93a1db602c7cdcf2a569bf8e0f4a8e52"}

[commit-bot: I haz the power, 2017-06-14 23:41:42]

Description was changed from

==========
Avoid use-after-free when InterstitialPageImpl is being torn down.

The InterstitialPageNavigatorImpl was continuing to access parts
of a deleted WebContents (e.g., the NavigationController) after its
corresponding InterstitialPageImpl was disabled.  This CL avoids
the problem by checking for the disabled state.

BUG=730592
TEST=NavigationHandleImpl crashes go away.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Avoid use-after-free when InterstitialPageImpl is being torn down.

The InterstitialPageNavigatorImpl was continuing to access parts
of a deleted WebContents (e.g., the NavigationController) after its
corresponding InterstitialPageImpl was disabled.  This CL avoids
the problem by checking for the disabled state.

BUG=730592
TEST=NavigationHandleImpl crashes go away.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2934353002
Cr-Commit-Position: refs/heads/master@{#479544}
Committed:
https://chromium.googlesource.com/chromium/src/+/f1ead56e93a1db602c7cdcf2a569...
==========

[commit-bot: I haz the power, 2017-06-14 23:41:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f1ead56e93a1db602c7cdcf2a569...