Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2934223002:
Utilize ComputeInlineBoxPosition in early-return style (Closed)
|
Created:
3 years, 6 months ago by yosin_UTC9 Modified:
3 years, 6 months ago CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUtilize ComputeInlineBoxPositionTempalte() in early-return style
This patch changes |ComputeInlineBoxPositionTemplate()| to utilize early-return
style to limit scope variable |inline_box|, which is the result of the function,
for improving code health.
BUG=707656
TEST=n/a; no behavior changes
Review-Url: https://codereview.chromium.org/2934223002
Cr-Commit-Position: refs/heads/master@{#479610}
Committed: https://chromium.googlesource.com/chromium/src/+/06b859c5dac92e22ea6db5c59643ce574d58ea3c
Patch Set 1 : 2017-06-14T18:03:38 #
Total comments: 2
Patch Set 2 : 2017-06-15T11:32:36 #Messages
Total messages: 19 (12 generated)
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== 2017-06-14T18:03:38 BUG=707656 2017-06-14T18:03:20 ========== to ========== Utilize ComputeInlineBoxPositionTempalte() in early-return style This patch changes |ComputeInlineBoxPositionTemplate()| to utilize early-return style to limit scope variable |inline_box|, which is the result of the function, for improving code health. BUG=707656 TEST=n/a; no behavior changes ==========
yosin@chromium.org changed reviewers: + xiaochengh@chromium.org, yoichio@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2934223002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (right): https://codereview.chromium.org/2934223002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/editing/VisibleUnits.cpp:825: { nit: Please add a TODO for removing this extra scope.
Thanks for reviewing! Committing... https://codereview.chromium.org/2934223002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (right): https://codereview.chromium.org/2934223002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/editing/VisibleUnits.cpp:825: { On 2017/06/14 at 18:33:58, Xiaocheng wrote: > nit: Please add a TODO for removing this extra scope. Done.
The CQ bit was checked by yosin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xiaochengh@chromium.org Link to the patchset: https://codereview.chromium.org/2934223002/#ps20001 (title: "2017-06-15T11:32:36")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497496589362050,
"parent_rev": "2be2fd5753b6e77d238d1f23f8c0e8a6806147b7", "commit_rev":
"06b859c5dac92e22ea6db5c59643ce574d58ea3c"}
Message was sent while issue was closed.
Description was changed from ========== Utilize ComputeInlineBoxPositionTempalte() in early-return style This patch changes |ComputeInlineBoxPositionTemplate()| to utilize early-return style to limit scope variable |inline_box|, which is the result of the function, for improving code health. BUG=707656 TEST=n/a; no behavior changes ========== to ========== Utilize ComputeInlineBoxPositionTempalte() in early-return style This patch changes |ComputeInlineBoxPositionTemplate()| to utilize early-return style to limit scope variable |inline_box|, which is the result of the function, for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2934223002 Cr-Commit-Position: refs/heads/master@{#479610} Committed: https://chromium.googlesource.com/chromium/src/+/06b859c5dac92e22ea6db5c59643... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/06b859c5dac92e22ea6db5c59643... |
