Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2934153002: Add virtual ProfileIOData methods related to URLRequestContext creation. (Closed)

Created:
3 years, 6 months ago by mmenke
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add virtual ProfileIOData methods related to URLRequestContext creation. Want to get all main URLRequestContext setup code in one method, and then move that method over to using URLRequestContextBuilder. BUG=715695

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -83 lines) Patch
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 1 2 chunks +0 lines, -28 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 2 chunks +50 lines, -55 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 3 chunks +30 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 6 chunks +55 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (10 generated)
mmenke
3 years, 6 months ago (2017-06-16 19:07:37 UTC) #9
And my other CL from Tuesday, which also ran into flaky failures...  This is how
I see merging merging URLrequestContext creation logic for the OTR and non-OTR
paths.  Once I have all creation in a single place, I'll switch over to using
the builder, then move out the builder delegate class, and the code to call
it...Making a BuilderBuilder (Which I want to eventually get rid of and move the
logic into the network service itself).

The multiple-method delegate approach seems a bit easier to incrementally remove
stuff from than pushing everything to the construction method, also more closely
fits with the existing code here.

Powered by Google App Engine
This is Rietveld 408576698