Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl.cc

Issue 2934043002: Use ContainsValue() instead of std::find() in chrome/browser/chromeos (Closed)
Patch Set: Removed #include<algorithm> when not required. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_manager_impl.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc b/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
index 492d64da56c5bf0ddaa925e5140e34edb3f90392..52c24d922601a2a83c8ed905b33600937872a805 100644
--- a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
@@ -22,6 +22,7 @@
#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h"
#include "base/metrics/sparse_histogram.h"
+#include "base/stl_util.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
@@ -76,8 +77,7 @@ ash::mojom::ImeInfo GetAshImeInfo(const InputMethodDescriptor& ime,
bool Contains(const std::vector<std::string>& container,
achuithb 2017/06/13 20:58:23 nit: We can eliminate this function as well by inl
Tripta 2017/06/14 07:36:17 Done.
const std::string& value) {
- return std::find(container.begin(), container.end(), value) !=
- container.end();
+ return base::ContainsValue(container, value);
}
enum InputMethodCategory {

Powered by Google App Engine
This is Rietveld 408576698