Avoid assert fault when using --trace-type-checks

runtime/vm/runtime_entry.cc

Index: runtime/vm/runtime_entry.cc
diff --git a/runtime/vm/runtime_entry.cc b/runtime/vm/runtime_entry.cc
index eb14e4031499a76d0781ea9ef422f75f6b61f8f2..00cc6c6871fc917224a8e4a9145d2e6a722c9699 100644
--- a/runtime/vm/runtime_entry.cc
+++ b/runtime/vm/runtime_entry.cc
@@ -389,7 +389,7 @@ static void PrintTypeCheck(const char* message,
   ASSERT(caller_frame != NULL);
 
   const AbstractType& instance_type =
-      AbstractType::Handle(instance.GetType(Heap::kNew));
+      AbstractType::Handle(instance.GetType(Heap::kOld));

[rmacnak, 2017/06/12 23:46:31]

We implement Object.runtimeType in terms of Instance::GetType(Heap::kNew),
specifically into new space because Flutter calls it often, so I think we need
this to work. Perhaps somewhere in type instantiation we use the passed-in space
to allocate a class when we should use old?

   ASSERT(instance_type.IsInstantiated());
   if (type.IsInstantiated()) {
     OS::PrintErr("%s: '%s' %" Pd " %s '%s' %" Pd " (pc: %#" Px ").\n", message,