Avoid assert fault when using --trace-type-checks

runtime/vm/runtime_entry.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/runtime_entry.h"
 
 #include "vm/assembler.h"
 #include "vm/ast.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
@@ skipping 371 matching lines @@
                            const AbstractType& type,
                            const TypeArguments& instantiator_type_arguments,
                            const TypeArguments& function_type_arguments,
                            const Bool& result) {
   DartFrameIterator iterator(Thread::Current(),
                              StackFrameIterator::kNoCrossThreadIteration);
   StackFrame* caller_frame = iterator.NextFrame();
   ASSERT(caller_frame != NULL);
 
   const AbstractType& instance_type =
-      AbstractType::Handle(instance.GetType(Heap::kNew));
+      AbstractType::Handle(instance.GetType(Heap::kOld));

[rmacnak, 2017/06/12 23:46:31]

We implement Object.runtimeType in terms of Instance::GetType(Heap::kNew),
specifically into new space because Flutter calls it often, so I think we need
this to work. Perhaps somewhere in type instantiation we use the passed-in space
to allocate a class when we should use old?

   ASSERT(instance_type.IsInstantiated());
   if (type.IsInstantiated()) {
     OS::PrintErr("%s: '%s' %" Pd " %s '%s' %" Pd " (pc: %#" Px ").\n", message,
                  String::Handle(instance_type.Name()).ToCString(),
                  Class::Handle(instance_type.type_class()).id(),
                  (result.raw() == Bool::True().raw()) ? "is" : "is !",
                  String::Handle(type.Name()).ToCString(),
                  Class::Handle(type.type_class()).id(), caller_frame->pc());
   } else {
     // Instantiate type before printing.
@@ skipping 1951 matching lines @@
   const intptr_t new_size = 2 * old_size;
   const intptr_t elm_size = old_data.ElementSizeInBytes();
   const TypedData& new_data =
       TypedData::Handle(TypedData::New(cid, new_size, Heap::kOld));
   TypedData::Copy(new_data, 0, old_data, 0, old_size * elm_size);
   typed_data_cell.SetAt(0, new_data);
   arguments.SetReturn(new_data);
 }
 
 }  // namespace dart