Make --enable-benchmarking not affect metrics recording.

Make --enable-benchmarking not affect metrics recording.

Previously, it would cause metrics to be in a special mode
where metrics are recorded but never reported, which caused
unbounded accumulation of data, such as user actions, in the
UMA protos. This test-only mode didn't seem necessary, so
removing it.

This also allowed a bunch of simplification, by removing a
client interface and its implementation, moving a switch to the
metrics component and removing some ios versions of the code.

BUG=730091
Review-Url: https://codereview.chromium.org/2933953002
Cr-Commit-Position: refs/heads/master@{#479511}
Committed: https://chromium.googlesource.com/chromium/src/+/de445d97963c2efe33e244fa60678173a6a3c2c8

[Alexei Svitkine (slow), 2017-06-12 21:13:47]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 21:14:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-06-12 21:19:37]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 21:19:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-06-12 21:24:06]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 21:24:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-06-12 21:26:31]

Description was changed from

==========
Make --enable-benchmarking not affect metrics recording.

Previously, it would cause metrics to be in a special mode
where metrics are recorded but never reported, which caused
unbounded accumulation of data, such as user actions, in the
UMA protos. This test-only mode didn't seem necessary, so
removing it.

BUG=730091
==========

to

==========
Make --enable-benchmarking not affect metrics recording.

Previously, it would cause metrics to be in a special mode
where metrics are recorded but never reported, which caused
unbounded accumulation of data, such as user actions, in the
UMA protos. This test-only mode didn't seem necessary, so
removing it.

This also allowed a bunch of simplification, by removing a
client interface and its implementation, moving a switch to the
metrics component and removing some ios versions of the code.

BUG=730091
==========

[Alexei Svitkine (slow), 2017-06-12 21:26:40]

Patchset #2 (id:20001) has been deleted

[Alexei Svitkine (slow), 2017-06-12 21:26:55]

Patchset #1 (id:1) has been deleted

[Alexei Svitkine (slow), 2017-06-12 21:27:51]

asvitkine@chromium.org changed reviewers:
+ rkaplow@chromium.org

[commit-bot: I haz the power, 2017-06-12 22:54:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 22:54:21]

Dry run: This issue passed the CQ dry run.

[etienneb, 2017-06-13 15:53:48]

etienneb@chromium.org changed reviewers:
+ etienneb@chromium.org

[etienneb, 2017-06-13 15:54:08]

etienneb@chromium.org changed reviewers:
- etienneb@chromium.org

[rkaplow, 2017-06-14 17:41:49]

lgtm

[Alexei Svitkine (slow), 2017-06-14 17:51:47]

asvitkine@chromium.org changed reviewers:
+ lpromero@chromium.org

[Alexei Svitkine (slow), 2017-06-14 17:51:48]

+lpromero for ios/ OWNERS

[Alexei Svitkine (slow), 2017-06-14 17:53:31]

asvitkine@chromium.org changed reviewers:
+ rohitrao@chromium.org
- lpromero@chromium.org

[Alexei Svitkine (slow), 2017-06-14 17:53:32]

-lpromero +rohitrao

Since I also need ios/ owners for ios/chrome/browser/chrome_switches.cc - which
lpromero@ doesn't cover.

[rohitrao (ping after 24h), 2017-06-14 20:01:07]

ios lgtm

[Alexei Svitkine (slow), 2017-06-14 20:01:37]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2017-06-14 20:02:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 21:38:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497470497231940,
"parent_rev": "edfd8e459c8133fa9b042839fe4edfbf260c3633", "commit_rev":
"de445d97963c2efe33e244fa60678173a6a3c2c8"}

[commit-bot: I haz the power, 2017-06-14 21:38:16]

Description was changed from

==========
Make --enable-benchmarking not affect metrics recording.

Previously, it would cause metrics to be in a special mode
where metrics are recorded but never reported, which caused
unbounded accumulation of data, such as user actions, in the
UMA protos. This test-only mode didn't seem necessary, so
removing it.

This also allowed a bunch of simplification, by removing a
client interface and its implementation, moving a switch to the
metrics component and removing some ios versions of the code.

BUG=730091
==========

to

==========
Make --enable-benchmarking not affect metrics recording.

Previously, it would cause metrics to be in a special mode
where metrics are recorded but never reported, which caused
unbounded accumulation of data, such as user actions, in the
UMA protos. This test-only mode didn't seem necessary, so
removing it.

This also allowed a bunch of simplification, by removing a
client interface and its implementation, moving a switch to the
metrics component and removing some ios versions of the code.

BUG=730091

Review-Url: https://codereview.chromium.org/2933953002
Cr-Commit-Position: refs/heads/master@{#479511}
Committed:
https://chromium.googlesource.com/chromium/src/+/de445d97963c2efe33e244fa6067...
==========

[commit-bot: I haz the power, 2017-06-14 21:38:18]

Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/de445d97963c2efe33e244fa6067...