gfx/ui/color_profile: add color profile cache on win

gfx/ui/color_profile: add color profile cache on win

Windows stores system color profiles on disk. To avoid disk reads
and the jank that that can cause, add a color profile cache keyed
by device name.

Here define/implement the cache interface. Make the cache thread-
safe to allow safe access from any blocking pool thread.

The cache key is a wide string for now and I might change that to
an int64 device id in a subsequent patch, we'll see.

BUG=368694
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273786

[sky, 2014-05-28 15:31:21]

https://codereview.chromium.org/293393008/diff/1/ui/gfx/color_profile_win.cc
File ui/gfx/color_profile_win.cc (right):

https://codereview.chromium.org/293393008/diff/1/ui/gfx/color_profile_win.cc#...
ui/gfx/color_profile_win.cc:18: base::LazyInstance<ColorProfileMap>::Leaky
g_color_profile_map =
Seems like you only want ColorProfileCache as the variable. The lock and map
should be members.

https://codereview.chromium.org/293393008/diff/1/ui/gfx/color_profile_win.cc#...
ui/gfx/color_profile_win.cc:20: base::LazyInstance<base::Lock>::Leaky
g_color_profile_map_lock;
These are not globals, remove the g_.

https://codereview.chromium.org/293393008/diff/1/ui/gfx/color_profile_win.cc#...
ui/gfx/color_profile_win.cc:22: struct ColorProfileCache {
Make this a class (see
https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.shtml?cl=head#...
for when to use structs).

https://codereview.chromium.org/293393008/diff/1/ui/gfx/color_profile_win.cc#...
ui/gfx/color_profile_win.cc:33: const char* data = it->second.data();
*profile = it->second; ?

https://codereview.chromium.org/293393008/diff/1/ui/gfx/color_profile_win.cc#...
ui/gfx/color_profile_win.cc:38: void insert(std::wstring device, const
std::vector<char>& profile) {
const std::wstring&

https://codereview.chromium.org/293393008/diff/1/ui/gfx/color_profile_win.cc#...
ui/gfx/color_profile_win.cc:45: bool erase(std::wstring device) {
const std::wstring&

[Noel Gordon, 2014-05-29 10:50:54]

Thank you.  Made all the changes you suggested.  PTAL.

[sky, 2014-05-29 15:31:31]

LGTM

https://codereview.chromium.org/293393008/diff/20001/ui/gfx/color_profile_win.cc
File ui/gfx/color_profile_win.cc (right):

https://codereview.chromium.org/293393008/diff/20001/ui/gfx/color_profile_win...
ui/gfx/color_profile_win.cc:15: class ColorProfileCache {
Add description.

https://codereview.chromium.org/293393008/diff/20001/ui/gfx/color_profile_win...
ui/gfx/color_profile_win.cc:19: bool find(const std::wstring& device,
std::vector<char>* profile) {
All your function names should be camelcase, eg Find and Insert.

https://codereview.chromium.org/293393008/diff/20001/ui/gfx/color_profile_win...
ui/gfx/color_profile_win.cc:52: };
DISALLOW_COPY_AND_ASSIGN.

[Noel Gordon, 2014-05-30 01:43:50]

Yeap all done, submitting.

[Noel Gordon, 2014-05-30 01:44:00]

The CQ bit was checked by noel@chromium.org

[commit-bot: I haz the power, 2014-05-30 01:45:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noel@chromium.org/293393008/40001

[commit-bot: I haz the power, 2014-05-30 10:25:04]

Change committed as 273786