gfx/ui/color_profile: add color profile cache on win

ui/gfx/color_profile_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/color_profile.h"
 
+#include <map>
 #include <windows.h>
 
 #include "base/file_util.h"
+#include "base/lazy_instance.h"
+#include "base/synchronization/lock.h"
 
 namespace gfx {
 
+typedef std::map<std::wstring, std::vector<char> > ColorProfileMap;
+
+base::LazyInstance<ColorProfileMap>::Leaky g_color_profile_map =

[sky, 2014/05/28 15:31:21]

Seems like you only want ColorProfileCache as the variable. The lock and map
should be members.

+    LAZY_INSTANCE_INITIALIZER;
+base::LazyInstance<base::Lock>::Leaky g_color_profile_map_lock;

[sky, 2014/05/28 15:31:21]

These are not globals, remove the g_.

+
+struct ColorProfileCache {

[sky, 2014/05/28 15:31:21]

Make this a class (see
https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.shtml?cl=head#...
for when to use structs).

+  ColorProfileCache() {}
+
+  bool find(std::wstring device, std::vector<char>* profile) {
+    base::AutoLock lock(g_color_profile_map_lock.Get());
+
+    ColorProfileMap* cache = g_color_profile_map.Pointer();
+    ColorProfileMap::const_iterator it = cache->find(device);
+    if (it == cache->end())
+      return false;
+
+    const char* data = it->second.data();

[sky, 2014/05/28 15:31:21]

*profile = it->second; ?

+    profile->assign(data, data + it->second.size());
+    return true;
+  }
+
+  void insert(std::wstring device, const std::vector<char>& profile) {

[sky, 2014/05/28 15:31:21]

const std::wstring&

+    base::AutoLock lock(g_color_profile_map_lock.Get());
+
+    ColorProfileMap* cache = g_color_profile_map.Pointer();
+    (*cache)[device] = profile;
+  }
+
+  bool erase(std::wstring device) {

[sky, 2014/05/28 15:31:21]

const std::wstring&

+    base::AutoLock lock(g_color_profile_map_lock.Get());
+
+    ColorProfileMap* cache = g_color_profile_map.Pointer();
+    ColorProfileMap::iterator it = cache->find(device);
+    if (it == cache->end())
+      return false;
+
+    cache->erase(device);
+    return true;
+  }
+
+  void clear() {
+    base::AutoLock lock(g_color_profile_map_lock.Get());
+
+    ColorProfileMap* cache = g_color_profile_map.Pointer();
+    cache->clear();
+  }
+};
+
 bool GetDisplayColorProfile(const gfx::Rect& bounds,
                             std::vector<char>* profile) {
   if (bounds.IsEmpty())
     return false;
   // TODO(noel): implement.
   return false;
 }
 
 void ReadColorProfile(std::vector<char>* profile) {
   // TODO: support multiple monitors.
   HDC screen_dc = GetDC(NULL);
   DWORD path_len = MAX_PATH;
   WCHAR path[MAX_PATH + 1];
 
   BOOL result = GetICMProfile(screen_dc, &path_len, path);
   ReleaseDC(NULL, screen_dc);
   if (!result)
     return;
   std::string profileData;
   if (!base::ReadFileToString(base::FilePath(path), &profileData))
     return;
   size_t length = profileData.size();
   if (gfx::InvalidColorProfileLength(length))
     return;
   profile->assign(profileData.data(), profileData.data() + length);
 }
 
 }  // namespace gfx