Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2933923003: Ensure that all CompositorView callbacks are complete when entering VR. (Closed)

Created:
3 years, 6 months ago by amp
Modified:
3 years, 6 months ago
Reviewers:
cjgrant
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Ensure that all CompositorView callbacks are complete when entering VR. BUG=729164 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2930113002 Cr-Original-Commit-Position: refs/heads/master@{#478698} Review-Url: https://codereview.chromium.org/2933923003 Cr-Commit-Position: refs/branch-heads/3112@{#323} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/c006f6a1b6d7ff89d1ca8fd446b7e41994ccf5f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java View 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
amp
Drover merge to 60, need committer lgtm
3 years, 6 months ago (2017-06-13 18:01:34 UTC) #2
cjgrant
lgtm
3 years, 6 months ago (2017-06-13 18:07:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933923003/1
3 years, 6 months ago (2017-06-13 18:08:43 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 18:09:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c006f6a1b6d7ff89d1ca8fd446b7...

Powered by Google App Engine
This is Rietveld 408576698